fix(definition): implement on demand parsing for accurate first click definition jump#16
Merged
ntoulasm merged 3 commits intoMar 4, 2026
Conversation
previously the `extractSymbols` was returning only symbols which broke diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue where jumping to a definition in a previously unopened file would default to the top of the document. By extracting the symbol extraction logic into a reusable utility, the server now performs "Just-In-Time" parsing of the files in workspace.
Key Changes
definition.ts) to check for the existence of the target file in the symbol table and parses it from disk if missing.server.tstoutils.tsto reuse it in the definition provider.launch.json)outFilesto also match/out/providersas previous refactoring broke the debugger.