fix: OOM crash #385
Merged
fix: OOM crash #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were facing OOM crash.
It happens because we load whole file into memory to get its size:
In this PR I'm using
CGImageSourceCreateWithURLto avoid loading whole file into memory until it's really needed.Also added more guards and removed
!operators (which eventually may lead to silent crashes and don't propagate error to JS).Changelog
[ios] [bugfix] - use
CGImageSourceCreateWithURLto avoid OOM crashTest Plan
Try to load 1000 RAW images simultaneosly and get size of all of them via
Promise.all([getImageMetadata...])