Remove withRouter (2/2)#3009
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3009 +/- ##
==========================================
+ Coverage 47.79% 55.56% +7.76%
==========================================
Files 254 255 +1
Lines 5314 5311 -3
Branches 1220 1216 -4
==========================================
+ Hits 2540 2951 +411
+ Misses 2774 2360 -414
Continue to review full report at Codecov.
|
|
Deployment preview for |
taneliang
force-pushed
the
eliang/even-more-fc
branch
from
6444639 to
3ee467b
Compare
taneliang
commented
Dec 3, 2020
| isExact?: boolean; | ||
| }; | ||
|
|
||
| // This can also be Location, but no test case use that for now so we leave it |
Member
Author
There was a problem hiding this comment.
createMemoryHistory's initialEntries can only be a string[], so I think this comment is outdated.
To upgrade @types/react-router from 5.0.x to 5.1.x, which adds new React Router hooks.
The JSON has nothing to do with the moduleList.json from our API, but, confusingly, has the same words in the name.
So that it can be memoized by `useSelector`
…) selectors For use with `useSelector`
This was referenced Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues from #3007.
There's 1 remaining
withRoutercallsite inVenuesContainer, but I'll fix that in a separate PR as the venues components looks like they're due for an overhaul.I've fixed the noob React Testing Library mistakes in this PR, but to prevent this PR from ballooning further, I didn't fix the mistakes from #3007. I'll fix them in a follow up PR and add the Testing Library ESLint plugins. (Edit: Created issue #3031 instead)