Skip to content

Add Mobility page for ISBs, MRT info#3712

Open
kagiura wants to merge 14 commits into
nusmodifications:masterfrom
kagiura:kagiura/mobility
Open

Add Mobility page for ISBs, MRT info#3712
kagiura wants to merge 14 commits into
nusmodifications:masterfrom
kagiura:kagiura/mobility

Conversation

@kagiura
Copy link
Copy Markdown

@kagiura kagiura commented Apr 9, 2024 •
edited
Loading

Context: #3675

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 5:41pm
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 5:41pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2024

@kagiura is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

@kokrui kokrui linked an issue Apr 9, 2024 that may be closed by this pull request
Add Mobility page for ISBs, MRT info #3675
Open
13 tasks
@hewliyang hewliyang mentioned this pull request Jun 13, 2024
Closed
kagiura added 12 commits November 17, 2024 22:01
@kagiura @zwliew
feat: ✨ basic implementation of mobility page (for ISBs)
2b0bf12
@kagiura @zwliew
refactor: 🚨 fixed dependency loop + fixed SVCs with gaps during the d…
f1e5b47 
…ay to show "resume" status properly
@kagiura @zwliew
refactor: ♻️ refactoring bus apis / util functions
70374d5
@kagiura @zwliew
refactor: ♻️ separate api errors and actually having no more buses
a679805
@kagiura @zwliew
chore: 🗃️ update schedule
4621d91
@kagiura @zwliew
fix: 👽️ new proxy api base url added
47f1449
@kagiura @zwliew
refactor: ✨ show which services are directly accessible from any sele…
28f5887 
…cted stop
@kagiura @zwliew
fix: 🐛 bug fixes (auto campus switch, term/holiday distinction)
35aebf7
@kagiura @zwliew
refactor: ♻️ refactored + optimized the isb pages
c3aefa6
@kagiura @zwliew
feat: 🍱 added bus icons (no implementation yet)
c5a8fe6
@kagiura @zwliew
fix: 🐛 fix mobile having slight horizontal scrolll
be0b2a8
@kagiura @zwliew
refactor: 💄 only hide footer on desktop (where it doesn't fit)
2df462d
@zwliew
Copy link
Copy Markdown
Member

zwliew commented Nov 17, 2024 •
edited
Loading

Incredible work with this :) I'll clean this up over the holidays and hopefully merge this change in its entirety by the end of the year! First, I plan to get the straightforward stuff like bus-stop-data and API changes merged.

zwliew referenced this pull request Nov 17, 2024
@zwliew
website: Revive ISB bus timings
a83078c 
Straightforward changes necessary to bring back bus timings in Venues.
Most of the work was done by @kagiura in PR #3172.
I'm mainly bringing in the bus stop data and API changes and gluing it
together to make it work with the original bus timing feature.
This was referenced Nov 18, 2024
Closed
Closed
jloh02
jloh02 reviewed Mar 6, 2026
View reviewed changes
Comment thread website/src/views/routes/Routes.tsx
Comment on lines +38 to +39
<Route path="/mobility/:type(service|stop)/:slug" component={MobilityContainer} />
<Route path="/mobility" component={MobilityContainer} />
Copy link
Copy Markdown
Member

@jloh02 jloh02 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps instead of that, it'd somehow be better to integrate with current "venues". we have an excess of tabs and this could potentially be a problem on mobile?

Comment thread website/src/apis/nextbus-new.ts
@@ -0,0 +1,26 @@
const baseURL = 'https://nnextbus.nusmods.com'; // TODO: wait until we have an api proxy
Copy link
Copy Markdown
Member

@jloh02 jloh02 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move this proxy to a serverless function of sorts? Or is something else better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jloh02 jloh02 jloh02 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Mobility page for ISBs, MRT info

3 participants

@kagiura @zwliew @jloh02