Conversation
…ing] + Add before/after all action registery
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces several new end-to-end test scenarios for the Instance Setting page, while also enhancing test infrastructure and adding new data-testid attributes for improved element targeting. Key changes include:
- New E2E tests and fixtures for instance settings, including before_all/after_all actions.
- Updates to frontend components with additional data-testid attributes for better test reliability.
- Enhancements in API client and registry actions to support class-level actions in tests.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/scenarios/test_instance_setting.py | Added multiple tests for accessing different instance setting menus and interactions. |
| test/e2e/scenarios/test_instance_create.py | Adjusted timeout configuration to improve stability. |
| test/e2e/registry/actions.py | Introduced class-level action protocols and updated action registration logic. |
| test/e2e/pages/* | Added new page objects and methods to support instance settings navigation. |
| frontend/src/* | Enhanced Instance-related components with new data-testid attributes and improved element targeting. |
| backend/src/core/startup.py | Updated database initialization to cleanup test databases on startup only. |
Comments suppressed due to low confidence (2)
frontend/src/components/Instance/Setting/AccessMenu.tsx:81
- The test id 'reset-root-password' is used on both an input field and a button. Consider using distinct identifiers (e.g., 'reset-root-password-input' and 'reset-root-password-button') to prevent ambiguity in tests.
data-testid="reset-root-password"
test/e2e/pages/instance/instance_setting_page.py:96
- [nitpick] The method name 'access_menu_should_be_not_be_available' is awkward. Consider renaming it to 'access_menu_should_not_be_available' for clarity.
def access_menu_should_be_not_be_available(self):
Collaborator
Author
|
@nut1414 pls help review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test:
Console tests are flaky as hell