Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive end‑to‑end tests for the Admin Instance Plan Page and updates related page objects, data models, and configuration files to support the new admin plan functionalities.
- Adds new e2e test scenarios for creating, editing, and deleting instance plans.
- Updates page objects and test data models to support the admin UI interactions.
- Adjusts frontend test IDs and configuration settings in Docker and backend infra.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/scenarios/test_admin_instance_plan.py | New tests for admin instance plan management scenarios. |
| test/e2e/pages/common/side_nav_bar.py | Added admin side navbar items for system, users, plans, and credits. |
| test/e2e/pages/admin/admin_instance_plan_page.py | Introduces a page object for admin instance plan page operations. |
| test/e2e/pages/admin/init.py | Exports the new AdminInstancePlanPage. |
| test/e2e/data/models.py | Modifies InstancePlanData by making instance_plan_id optional. |
| test/e2e/data/constant.py | Updates Currency precision to 4. |
| frontend/src/pages/Admin/InstancePlanManagePage.tsx | Adds data-testid attributes for reliable element selection. |
| docker/app/docker-compose.yaml | Adjusts the VITE_API_URL argument by removing its default value. |
| backend/src/infra/config.py | Enhances LXD_HOST resolution with a fallback strategy. |
Comments suppressed due to low confidence (1)
test/e2e/data/models.py:51
- Ensure that Optional is imported from the typing module to avoid a NameError.
instance_plan_id: Optional[int] = None
Collaborator
Author
|
@nut1414 pls help review |
nut1414
requested changes
Apr 26, 2025
Owner
nut1414
left a comment
There was a problem hiding this comment.
Shouldnot be able to delete plan when insance exist missi g
Collaborator
Author
Owner
|
I mean just assertion for that button. Button should not exist. |
nut1414
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary