Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new end-to-end test scenarios for the User Manage page while improving consistency in date formatting across tests.
- Added a new utility function (format_date_for_instance_card) to format dates for instance cards.
- Updated multiple test fixtures to use the now_formatted() function instead of datetime.now() for standardized date strings.
- Extended and adjusted page objects and UI components to support these tests with new data-testid attributes.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/utils/datetime_utils.py | Added date formatting utility for instance cards |
| test/e2e/scenarios/test_user_manage.py | New E2E test scenarios and fixtures for User Manage functionality |
| test/e2e/scenarios/test_user_billing.py, etc. | Replaced datetime.now() with now_formatted() for consistency |
| test/e2e/pages/admin/user_manage_page.py | Updated page object with new data-testid attributes for testing |
| test/e2e/data/models.py | Changed created_at and last_updated_at types for string consistency |
| frontend/src/pages/Admin/UserManagePage.tsx | Added data-testid attributes and updated key extractor for improved tests |
| frontend/src/components/Common/ItemCard.tsx | Added data-testid attribute for card header |
Collaborator
Author
|
@nut1414 pls help review |
nut1414
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary