Skip to content

Fix user can create instance with insufficient balance#49

Merged
nut1414 merged 1 commit into
mainfrom
CB-fix-bug-3
May 5, 2025
Merged

Fix user can create instance with insufficient balance#49
nut1414 merged 1 commit into
mainfrom
CB-fix-bug-3

Conversation

@jinnaWan
Copy link
Copy Markdown
Collaborator

@jinnaWan jinnaWan commented May 5, 2025

No description provided.

@jinnaWan jinnaWan requested review from Copilot and nut1414 May 5, 2025 02:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the issue where a user could create an instance without having sufficient balance by introducing an early wallet validation check.

  • Introduces a balance check before creating the instance in LXD
  • Removes a redundant balance check after the instance creation process

Comment thread backend/src/core/service/instance.py
@jinnaWan
Copy link
Copy Markdown
Collaborator Author

jinnaWan commented May 5, 2025

@nut1414 pls help review

@nut1414 nut1414 merged commit 3f17479 into main May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants