Revert partially constructed segments on-error in segment init function#407
Closed
dagardner-nv wants to merge 85 commits intonv-morpheus:branch-24.03from
Closed
Conversation
…d issue isn't relevent to this test
This reverts commit 6914da7.
…s different builds of llvm packages to fix CI
…inconsistent-pipe
… into david-inconsistent-pipe
…inconsistent-pipe
…cond segments [no ci]
…nts check_active_connection from mistakenly returning true for a holder where init_owned_edge has been called but neither the init_connected_edge method or the add_connector method have not been called
…gressProvider" This reverts commit 111d7f8.
… has already been destroyed, avoid using the m_parent if the node has been destroyed
…inconsistent-segments-and-edges-named
dagardner-nv
changed the title
dagardner-nv
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.11 #407 +/- ##
================================================
- Coverage 74.03% 73.84% -0.20%
================================================
Files 394 385 -9
Lines 13955 13710 -245
Branches 1053 1033 -20
================================================
- Hits 10332 10124 -208
+ Misses 3623 3586 -37
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 70 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Author
|
Closing in favor of #434 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
inner_edgeheld by theForwardingEgressProvideris disconnected.Fixes #360
Fixes #400
Fixes #401
Checklist