Skip to content

Revert partially constructed segments on-error in segment init function #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dagardner-nv wants to merge 31 commits into
base: branch-24.10
Choose a base branch
from

Merge branch 'branch-24.10' of github.com:nv-morpheus/MRC into david-…

6040afb
Select commit
Loading
Failed to load commit list.
Open

Revert partially constructed segments on-error in segment init function #434

Merge branch 'branch-24.10' of github.com:nv-morpheus/MRC into david-…
6040afb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 6, 2026 in 0s

74.16% (+0.09%) compared to bceb7ef

View this Pull Request on Codecov

74.16% (+0.09%) compared to bceb7ef

Details

Codecov Report

❌ Patch coverage is 72.82609% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.16%. Comparing base (bceb7ef) to head (6040afb).
⚠️ Report is 15 commits behind head on branch-24.10.

Files with missing lines Patch % Lines
cpp/mrc/include/mrc/edge/edge_holder.hpp 25.00% 12 Missing ⚠️
...pp/mrc/src/internal/pipeline/pipeline_instance.cpp 78.94% 4 Missing ⚠️
cpp/mrc/include/mrc/manifold/egress.hpp 50.00% 2 Missing ⚠️
cpp/mrc/include/mrc/manifold/ingress.hpp 50.00% 2 Missing ⚠️
cpp/mrc/include/mrc/node/source_properties.hpp 93.33% 1 Missing ⚠️
cpp/mrc/include/mrc/segment/ingress_port.hpp 75.00% 1 Missing ⚠️
cpp/mrc/include/mrc/segment/object.hpp 0.00% 1 Missing ⚠️
cpp/mrc/include/mrc/segment/runnable.hpp 66.66% 1 Missing ⚠️
cpp/mrc/src/public/manifold/manifold.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #434      +/-   ##
================================================
+ Coverage         74.07%   74.16%   +0.09%     
================================================
  Files               403      403              
  Lines             14401    14471      +70     
  Branches           1132     1137       +5     
================================================
+ Hits              10668    10733      +65     
- Misses             3733     3738       +5
Files with missing lines Coverage Δ
...pp/mrc/include/mrc/manifold/composite_manifold.hpp 88.88% <100.00%> (+2.22%) ⬆️
cpp/mrc/include/mrc/manifold/interface.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/node/queue.hpp 100.00% <100.00%> (ø)
cpp/mrc/include/mrc/node/rx_node.hpp 93.47% <ø> (ø)
cpp/mrc/include/mrc/segment/component.hpp 100.00% <100.00%> (ø)
...pp/mrc/src/internal/segment/builder_definition.cpp 84.11% <100.00%> (+0.88%) ⬆️
cpp/mrc/src/internal/segment/segment_instance.cpp 84.12% <100.00%> (+0.52%) ⬆️
cpp/mrc/include/mrc/node/source_properties.hpp 77.55% <93.33%> (+2.55%) ⬆️
cpp/mrc/include/mrc/segment/ingress_port.hpp 77.27% <75.00%> (-0.51%) ⬇️
cpp/mrc/include/mrc/segment/object.hpp 50.96% <0.00%> (-0.50%) ⬇️
... and 6 more

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bceb7ef...6040afb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov