test(colors): add more sleeping time to ':Colorscheme' test#2382
Closed
abeldekat wants to merge 1 commit intonvim-mini:mainfrom
Closed
test(colors): add more sleeping time to ':Colorscheme' test#2382abeldekat wants to merge 1 commit intonvim-mini:mainfrom
abeldekat wants to merge 1 commit intonvim-mini:mainfrom
Conversation
Details: - Test ':Colorscheme'-'accepts several arguments' fails regularly, especially when repeating 'make test_colors' multiple times. The solution is to also use small_transition_time in the third step to compensate for time spent in the previous steps.
Member
|
Thanks for the PR! I adjusted the test a bit more to make it more concise and robust. Should be better now on latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
The total sleeping time in the test was exactly 3000 ms. With this PR, the time is 3020 ms.