Skip to content

fix(files): remember explorer's tabpage when file is opened in new tab#2389

Merged
echasnovski merged 2 commits intonvim-mini:backlogfrom
abeldekat:fix_files_switch_tab
Apr 25, 2026
Merged

fix(files): remember explorer's tabpage when file is opened in new tab#2389
echasnovski merged 2 commits intonvim-mini:backlogfrom
abeldekat:fix_files_switch_tab

Conversation

@abeldekat
Copy link
Copy Markdown
Member

Resolve #2388

@echasnovski
Copy link
Copy Markdown
Member

echasnovski commented Apr 24, 2026

Thanks for the PR!

This looks like the correct solution indeed. Would you mind please adding two tests:

  • One for close() returning nil and not changing the tabpage in the issue's scenario.
  • One for open() opening the explorer in the current tabpage in the issue's scenario.

@abeldekat abeldekat force-pushed the fix_files_switch_tab branch from 8c664b6 to 845b6b5 Compare April 24, 2026 20:22
@echasnovski echasnovski changed the base branch from main to backlog April 25, 2026 15:06
@echasnovski echasnovski merged commit 07b4d8d into nvim-mini:backlog Apr 25, 2026
12 checks passed
@echasnovski
Copy link
Copy Markdown
Member

This should now be part of the latest main. I've adjusted tests: replaced screenshot testing for correct opening with counting floating windows, made better coverage for use_latest argument of open(), and made both tests a bit more consistent with each other.

Thanks again for the PR!

@abeldekat
Copy link
Copy Markdown
Member Author

Great! Thanks.

@abeldekat abeldekat deleted the fix_files_switch_tab branch April 25, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mini.files] Opening mini.files after split to tab breaks future opens

3 participants