Skip to content

fix(animate): react to Nightly triggering WinScrolled on incsearch#2408

Closed
abeldekat wants to merge 1 commit intonvim-mini:mainfrom
abeldekat:test_animate
Closed

fix(animate): react to Nightly triggering WinScrolled on incsearch#2408
abeldekat wants to merge 1 commit intonvim-mini:mainfrom
abeldekat:test_animate

Conversation

@abeldekat
Copy link
Copy Markdown
Member

Details:

  • See PR 39308 in neovim/neovim

Related to #234

@echasnovski
Copy link
Copy Markdown
Member

Thanks for the PR!

If there is any logic change in the code, the commit is a fix, not a test(...).

Skipping an existing test on "future facing" Neovim version check is very unusual. It means that certain behavior was intended earlier but not it is not. The does not automatically animate result of 'incsearch' describes a behavior that is intended, so there should be a deliberate fix and not just MiniTest.skip().

@abeldekat abeldekat changed the title test(animate): react to Nightly triggering WinScrolled on incsearch fix(animate): react to Nightly triggering WinScrolled on incsearch May 6, 2026
Details:
- See PR 39308 in neovim/neovim

Related to nvim-mini#234
@abeldekat
Copy link
Copy Markdown
Member Author

As this is a blocking issue, I don't think I can solve it in a timely fashion. Closing in favor of a better solution...

@abeldekat abeldekat closed this May 6, 2026
@abeldekat abeldekat deleted the test_animate branch May 6, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants