feat: add bitbucket icon#639
Open
Skladnayazebra wants to merge 4 commits intonvim-tree:masterfrom
Open
Conversation
Skladnayazebra
commented
May 2, 2026
| ["vite.config.js"] = { icon = "", color = "#FFA800", cterm_color = "214", name = "ViteConfig" }, | ||
| ["vite.config.mjs"] = { icon = "", color = "#FFA800", cterm_color = "214", name = "ViteConfig" }, | ||
| ["vite.config.mts"] = { icon = "", color = "#FFA800", cterm_color = "214", name = "ViteConfig" }, | ||
| ["vite.config.ts"] = { icon = "", color = "#FFA800", cterm_color = "214", name = "ViteConfig" }, |
Author
There was a problem hiding this comment.
looks like these lines were padded by tabs, not spaces. Since I touch the whole file anyways, should I go ahead and reformat these with spaces? Or is it better to do in a separate PR?
Member
There was a problem hiding this comment.
Good spot.
Yes, please do change to spaces and regenerate. They will also be ordered correctly after that.
Skladnayazebra
commented
May 2, 2026
| ["QtProject.conf"] = { icon = "", color = "#40CD52", cterm_color = "77", name = "Qt" }, | ||
| ["_gvimrc"] = { icon = "", color = "#019833", cterm_color = "28", name = "Gvimrc" }, | ||
| ["_vimrc"] = { icon = "", color = "#019833", cterm_color = "28", name = "Vimrc" }, | ||
| ["bitbucket-pipelines.yml"] = { icon = "", color = "#2684FF", cterm_color = "33", name = "BitbucketPipelinesConfig" }, |
Member
There was a problem hiding this comment.
Dark and light icons look good.
Author
|
@alex-courtis hey there, I'm new here and I'm not sure if I'm supposed to signal anything else on top of creating the PR. Got any feedback? I left couple questions, too. |
alex-courtis
requested changes
May 7, 2026
Member
alex-courtis
left a comment
alex-courtis
left a comment
There was a problem hiding this comment.
Please:
- Fix formatting as discussed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an icon for bitbucket-pipelines.yml file.
I found 3 size variations of NF Bitbucket icon, tested all of them and chose medium-sized nf-md-bitbucket, it fits the best with other devicons:
HEX color is taken from the official icon.
Is it okay that the entire file got changed by formatter? I see that all other lines have 1 extra space now - looks like the name I added is the longest so far.
The new icon is on line 76.