Skip to content

Moved sensor assets from ROS2 Gem to ROS2SampleRobots Gem#886

Merged
jhanca-robotecai merged 3 commits into
o3de:developmentfrom
RobotecAI:pb/moved_sensors
Apr 15, 2025
Merged

Moved sensor assets from ROS2 Gem to ROS2SampleRobots Gem#886
jhanca-robotecai merged 3 commits into
o3de:developmentfrom
RobotecAI:pb/moved_sensors

Conversation

@pawelbudziszewski

Copy link
Copy Markdown
Member

What does this PR do?

Moved meshes, materials, and textures of sensors from ROS2 gem to ROS2SampleRobots gem (which already contains assets of 2 lidars)

This PR is in line with the changes proposed in RFC for simulation-related gems and templates

How was this PR tested?

Checked if prefabs load without warnings

Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai>
Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai>
Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai>
@pawelbudziszewski pawelbudziszewski requested review from a team as code owners April 14, 2025 13:24
@pawelbudziszewski pawelbudziszewski added the sig/simulation Categorizes an issue or PR as relevant to SIG Simulation label Apr 14, 2025

@jhanca-robotecai jhanca-robotecai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some inconsistency in the naming: LidarOS2 vs. OrbbeckCamera (should be CameraOrbbeck), but I would not care that much at this point.

@jhanca-robotecai jhanca-robotecai merged commit 6795685 into o3de:development Apr 15, 2025
@jhanca-robotecai jhanca-robotecai deleted the pb/moved_sensors branch April 15, 2025 09:38
jhanca-robotecai pushed a commit to RobotecAI/o3de-extras that referenced this pull request Apr 15, 2025
Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai>
jhanca-robotecai pushed a commit that referenced this pull request Apr 18, 2025
Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/simulation Categorizes an issue or PR as relevant to SIG Simulation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants