feat: add exit flag to allow for exiting after selection is made#38
feat: add exit flag to allow for exiting after selection is made#380xch4z wants to merge 1 commit intooNaiPs:mainfrom
Conversation
Resolves oNaiPs#37 This adds a new flag (`-e` or `--exit`) that exits the process after a selection is made when `dmenu-mac` is launched without arguments.
|
|
||
| func closeApp() { | ||
| clearFields() | ||
| if promptValue == "" { |
There was a problem hiding this comment.
This change isn't necessary, just saw this could be simplified as PipeListProvider.doAction terminates the app before this code is reached -- promptValue == "" will always evaluate to true.
|
@0xch4z thanks for your contribution! I think you're 100% right, we should be exiting the CLI after the selection is made. Would you mind change your PR so that is the default behavior? |
|
I was trying to implement one-time run as a default behaivour via adding I think it's a breaking change that affects the flow for all users. If we leave this flag as an option it won't break compatibility with the way of usual launch of the program. If we want to introduce a breaking change then maybe it's better to implement |
3 participants
Resolves #37
This adds a new flag (
-eor--exit) that exits the process after a selection is made whendmenu-macis launched without arguments.