Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this great library. I plan to use this a more in the future so I made a clj-kondo hook to help lint my code.
With this hook,
o/rulesetwill have this the following linting properties:whatblock.:whatblock will be usable in:whenand:thenblocksessionandmatchsymbol in:whenand:thenblocksessionsymbol in:then-finallyblock (:then-finallyblock will have no access tomatchand bindings from:whatblock)sessionandmatchsymbol in:whatblockI tested this in my 3 game projects that uses odoyle rules and the rules_test.cljc in this project using calva and all o/ruleset has no lint warning. the lsp feature like renaming and references work as expected as well. I also have confirmed the clj-kondo.exports is working correctly (in calva) by using this library as a git-deps of my fork. deps value below for convenience.
io.github.keychera/odoyle-rules {:git/sha "10447b7d8e3c9611fc9d59bc29d5a6d148d10556"}There maybe edge cases that I haven't found so I am also gonna ask around for feedback with any other clojurians that uses this library.
related issue: #22