Fix the logic for default value of USB_INTR_CFG_SET#30
Open
z0nt wants to merge 1 commit intoobdev:masterfrom
Open
Fix the logic for default value of USB_INTR_CFG_SET#30z0nt wants to merge 1 commit intoobdev:masterfrom
z0nt wants to merge 1 commit intoobdev:masterfrom
Conversation
Use `if` condition instead of `ifdef` for USB_COUNT_SOF macro which is consistent throughout the code base. USB_COUNT_SOF is set to 0 in usbconfig-prototype.h which causes interrupt to be set to falling edge instead of rising edge as it meant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
ifcondition instead ofifdefforUSB_COUNT_SOFmacro which is consistent throughout the code base.USB_COUNT_SOFis set to 0 inusbconfig-prototype.hwhich causes interrupt to be set to falling edge instead of rising edge as it meant.