feat(datagen): add SeedConfig with per-type seed resolution#143
Open
feat(datagen): add SeedConfig with per-type seed resolution#143
Conversation
Contributor
Author
This was referenced Apr 27, 2026
Base automatically changed from
dylanmyers/pipe-927-common-data-generation-package
to
main
May 8, 2026 17:02
Dylan-M
force-pushed
the
04-06-feat_datagen_add_seedconfig_with_per-type_seed_resolution
branch
from
31ca17f to
610f2ef
Compare
eKuG
requested changes
May 8, 2026
| func (s *SeedConfig) ResolveSeed(identityType string) int64 { | ||
| var override *int64 | ||
| switch identityType { | ||
| case "systems": |
There was a problem hiding this comment.
What happens when system is mentioned instead of systems. It would fall back to shared. I guess enums would be a better way to go forward. What do you think?
| // Shared seed for all identity types. 0 = generate random seed at startup. | ||
| Shared int64 | ||
|
|
||
| // Per-identity-type overrides. If set (non-nil), overrides Shared for that type. |
There was a problem hiding this comment.
Nit : Shared uses 0 as the “unset, randomize on Init” sentinel, which means callers cannot intentionally use shared seed 0 even though 0 is a valid deterministic math/rand seed. That quietly breaks the PR’s reproducibility contract for one legitimate input value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Adds
SeedConfig, which resolves a deterministic seed per identity type so generation across types is independently reproducible.Part of PIPE-927 common data generation package stack. Foundation for PIPE-785, PIPE-928, PIPE-943, and the rest of the simulator stack.
Checklist