Draft
Conversation
- pack_cstrs renamed to pack_constraints in Types.package - tpt_cstrs renamed to tpt_constraints in Typedtree.package_type - typ_cstrs renamed to typ_constraints in Typedtree.type_declaration - New Type_external/Ttype_external constructors for external types - New Tfunctor/Ttyp_functor constructors in type_desc/core_type_desc - New Local_opaque_item constructor in Shape.Uid - Typemod.path_of_module moved to Typedtree.path_of_module Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The way it works is not ideal: we create a synthetic parent id for each module argument (as they can be introduced multiple times with the same name in the same type expression). This id is hidden and we don't render links to hidden ids. This is slightly bad because: - The appearance of unresolved links suggest an error when there is no. - There is no way to distinguish module args from normal modules But let's say it is a good first step!
kit-ty-kate
reviewed
Mar 25, 2026
| "dune" {>= "3.21.0"} | ||
| "fpath" {>= "0.7.3"} | ||
| "ocaml" {>= "4.08.0" & < "5.5"} | ||
| "ocaml" {>= "4.08.0" & <= "5.5.1"} |
Member
There was a problem hiding this comment.
Suggested change
| "ocaml" {>= "4.08.0" & <= "5.5.1"} | |
| "ocaml" {>= "4.08.0" & < "5.6"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for 5.5 with:
The second one is trickier. In this PR, at least:
However, the path referencing the module argument appear as unresolved links: underlined in red, suggesting an error...
The state of the PR is draft because it needs to be cleaned up and improved, but I already open it in case someone wants to try odoc on OCaml 5.5.
🤖 Generated with @xvw