19.0 tutorials mekav #1095
Draft
19.0 tutorials mekav #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
added fist tale in ch-3 and security (permission rule for group) in ch-4 and start ch-5 , in that add views file
complete field, attribute , view in ch-5 and list and form in ch-6
mekav-odoo
force-pushed
the
19.0-tutorials-mekav
branch
from
c936ac4 to
6b0b9b8
Compare
mash-odoo
requested changes
Jan 2, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello @mekav-odoo,
Good work on the PR.
Please have a look at my comments and apply the needed changes.
mash-odoo
requested changes
Jan 8, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello,
Good Work going..
Here are some suggestions and questions..
estate/models/estate_property.py
Outdated
Comment on lines
40
to
43
| ("north", "North"), | ||
| ("south", "South"), | ||
| ("east", "East"), | ||
| ("west", "West"), |
implement statusbar widget, in List order model ordering & manual ordering and in form Attributes and options
mekav-odoo
force-pushed
the
19.0-tutorials-mekav
branch
from
4275261 to
9821fb8
Compare
implement statusbar widget, in List order model ordering & manual ordering and in form Attributes and options
add Attributes and options in List , default filter , filter domain in search and stat button
add Attributes and options in List , default filter , filter domain in search and stat button
done implementation of model inheritance & view inheritance to display the list of properties linked to a salesperson directly in the Settings / Users form view and implemented ondelete() and create() functions.
mash-odoo
requested changes
Jan 16, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello!
Good going on the task..
Here are a few questions and suggestions..
| property_ids = fields.One2many('estate.property', 'property_type') | ||
| sequence = fields.Integer() | ||
| offer_ids = fields.One2many('estate.property.offer', 'property_type_id') | ||
| offer_count = fields.Integer(compute='_compute_offer') |
There was a problem hiding this comment.
Suggested change
| offer_count = fields.Integer(compute='_compute_offer') | |
| offer_count = fields.Integer(compute='_compute_offer_count') |
| <group> | ||
| <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color'}"/> | ||
| <field name="state"/> | ||
| <field name="property_type" options="{'no_create_edit': true}"/> |
| def action_property_sold(self): | ||
| for record in self: | ||
| if record.state == 'cancelled': | ||
| raise UserError("cancelled property cannot be sold") |
There was a problem hiding this comment.
Explain the events where should I use UserError and ValidationError?
| <field name="arch" type="xml"> | ||
| <list editable="bottom" decoration-success="status=='accepted'" decoration-danger="status=='refused'"> | ||
| <field name="price"/> | ||
| <field name="status" optional="hide"/> |
There was a problem hiding this comment.
What's the purpose of using optional hide?
| <field name="name">properties</field> | ||
| <field name="res_model">estate.property</field> | ||
| <field name="view_mode">list,form</field> | ||
| <field name="context">{'search_default_active': True}</field> |
There was a problem hiding this comment.
This default search is used for filter, what if I want to make a default group by?
| ) | ||
| property_type = fields.Many2one('estate.property.type', string="property type") | ||
| salesman_id = fields.Many2one( | ||
| 'res.users', string="Salesman", default=lambda self: self.env.user |
Comment on lines
+18
to
+19
| <button name="action_accept" type="object" title="accept" icon="fa-check" invisible='status'/> | ||
| <button name="action_refuse" type="object" title="refuse" icon="fa-times" invisible='status'/> |
There was a problem hiding this comment.
How can I make these buttons invisible once I have accepted an offer?
Comment on lines
+44
to
+50
| <field name="property_ids"> | ||
| <list> | ||
| <field name="name" string="Title"/> | ||
| <field name="expected_price"/> | ||
| <field name="state"/> | ||
| </list> | ||
| </field> |
There was a problem hiding this comment.
What is the purpose of explicitly defining a list (tree) view here, even though the field is a One2many?
Won't it work just fine even if you write just this <field name="property_ids">?
Comment on lines
+8
to
+13
| <page name="preferences" position="after"> | ||
| <page name="Estate Property"> | ||
| <field name="property_ids"/> | ||
| </page> | ||
| </page> | ||
| </field> |
| <form string="Property Types"> | ||
| <sheet> | ||
| <header> | ||
| <button class="oe_stat_button" icon="fa-money" type="action" name="%(estate_property_offer_model_action)d"> |
There was a problem hiding this comment.
What does type action do? And what are the other types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module: Estate
Initialized the estate module for Odoo Technical Training. This includes the base model definitions, security access rights, and the initial user interface as outlined in the tutorial steps.