19.0 real estate tutorial jakan #1109

jakan-odoo · 2026-01-01T11:41:35Z

Chapter 4 is completed in this update.

Basic security access rules are added for the Estate module so users can access records correctly. Code style issues like missing white space and formatting problems are also fixed.

- Real Estate module created - Basic structure and required fields added - CHAPTER 1, 2, and 3

- Added basic security access for estate records - Fixed missing whitespace and formatting issues - Covers CHAPTER 4

robodoo · 2026-01-01T11:41:39Z

- Added form and list views for estate records - Added menu and action to access the module - Covers CHAPTER 5

- Added list, form, and search views - Added domains and group by options - Covers CHAPTER 6

mash-odoo

Hello @jakan-odoo,
Good start on the PR,
Please view the comments and apply the needed changes.

mash-odoo · 2026-01-02T12:54:41Z

estate/models/estate_property.py

+from odoo import fields, models
+from dateutil.relativedelta import relativedelta


For ordering of imports, refer this: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#imports

mash-odoo · 2026-01-02T12:56:10Z

estate/views/estate_property_views.xml

+    <record id="estate_property_list_view" model="ir.ui.view">
+        <field name="name">estate.property.list</field>


For naming a view: <model_name>_view_<view_type>, where view_type is kanban, form, list, search, …
You can refer this guideline: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming

mash-odoo · 2026-01-02T13:11:41Z

estate/views/estate_property_views.xml

+    <record id="estate_property_form_view" model="ir.ui.view">
+        <field name="name">estate.property.form</field>


Do same as suggested above

- Added Many2one relation between models - Improves data linking between records - Covers CHAPTER 7

- Added One2many and Many2many relations between models - Improves linking and management of related records - Covers CHAPTER 7

- Added computed fields for automatic values - Added onchange methods to update fields - Covers CHAPTER 8

- Created Sell, Cancel, Accept, and Refuse buttons - Buttons call related methods on the estate models - Buyer and selling price are set when an offer is accepted - Covers CHAPTER 9

mash-odoo

Hello,
Good going on the task..
Here are some suggestions..

mash-odoo · 2026-01-06T12:18:39Z

estate/views/estate_property_views.xml

+                <field name="bedrooms"/>
+                <field name="living_area"/>
+                <field name="selling_price"/>
+                <filter string="Available Properties" name="available properties" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>


Can we write this filter in any other way?

Yes ma'am,
We can write filter like this
<filter string="Available Properties" name="available_properties" domain="[('state', 'in', ('new', 'offer_received'))]"/>

mash-odoo · 2026-01-06T12:34:52Z

estate/views/estate_property_tag_views.xml

+            </form>
+        </field>
+    </record>
+</odoo>


Leave a line at the end of file

mash-odoo · 2026-01-06T12:39:38Z

estate/models/estate_property.py

+            ("north", "North"),
+            ("south", "South"),
+            ("east", "East"),
+            ("west", "West")])


Suggested change

("north", "North"),

("south", "South"),

("east", "East"),

("west", "West")])

('north', "North"),

('south', "South"),

('east', "East"),

('west', "West")])

mash-odoo · 2026-01-06T12:40:18Z

estate/models/estate_property.py

+            ('new', 'New'),
+            ('offer_received', 'Offer Received'),
+            ('offer_accepted', 'Offer Accepted'),
+            ('sold', 'Sold'),
+            ('cancelled', 'Cancelled'),


Suggested change

('new', 'New'),

('offer_received', 'Offer Received'),

('offer_accepted', 'Offer Accepted'),

('sold', 'Sold'),

('cancelled', 'Cancelled'),

('new', "New"),

('offer_received', "Offer Received"),

('offer_accepted', "Offer Accepted"),

('sold', "Sold"),

('cancelled', '"Cancelled"),

mash-odoo · 2026-01-06T12:40:53Z

estate/__manifest__.py

@@ -0,0 +1,20 @@
+{
+    'name': 'Real Estate',


Suggested change

'name': 'Real Estate',

'name': "Real Estate",

mash-odoo · 2026-01-06T12:41:15Z

estate/__manifest__.py

+    'version': '1.0',
+    'category': 'Real Estate',
+    'summary': 'Manage real estate properties',
+    'description': 'This module allows managing properties.',


Suggested change

'description': 'This module allows managing properties.',

'description': "This module allows managing properties.",

mash-odoo · 2026-01-08T09:50:40Z

estate/models/estate_property.py

+from dateutil.relativedelta import relativedelta
+from odoo import fields, models, api


For ordering of imports, refer this: https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#imports

- Added SQL constraints to ensure data validity - Added Python constraints for business rules - Covers CHAPTER 10

- Added inline views for related records - Applied widgets to improve user interface - Set default ordering using _order - CHAPTER 11

- Added maintenance request model with title, cost, and status - Ensured approved requests have a positive cost - Displayed total maintenance cost on the property - Prevented property sale when maintenance is not completed

- Replaced direct cost check with float_is_zero - Ensures correct validation for decimal precision

- Added manual ordering and widget options - Applied conditional button visibility using invisible - Made list views editable and some fields optional - Added decorations, default filters, and stat buttons - Covers CHAPTER 11

mash-odoo

Hello!
Thank you for your work..
Here are some suggestions and questions..

mash-odoo · 2026-01-12T12:33:32Z

estate/models/estate_property_offer.py

+    def action_accept(self):
+        for offer in self:
+            if offer.property_id.buyer_id:
+                raise UserError("Property already accepted")
+
+            other_offer = offer.property_id.offer_ids - offer
+            other_offer.write({'status': 'refused'})
+
+            offer.status = "accepted"
+            offer.property_id.buyer_id = offer.partner_id
+            offer.property_id.selling_price = offer.price
+        return True


Can you optimize this?

Yes ma'am I can optimize using write,

def action_accept(self): for offer in self: property_rec = offer.property_id if property_rec.buyer_id: raise UserError("Property already accepted") other_offer = property_rec.offer_ids - offer other_offer.write({'status': 'refused'}) offer.status = "accepted" property_rec.write({ 'buyer_id': offer.partner_id.id, 'selling_price': offer.price, 'state': 'sold', 'active': False, }) return True

mash-odoo · 2026-01-12T12:34:05Z

estate/models/estate_property_offer.py

+            offer.status = "refused"
+        return True
+
+    _check_offer_price_positive = models.Constraint(


Follow this conventions while declaring fields, constraints, methods or CRUD operations.

mash-odoo · 2026-01-12T12:34:26Z

estate/models/estate_property_type.py

+    _order = 'name'
+
+    name = fields.Char(required=True)
+


Suggested change

mash-odoo · 2026-01-12T12:38:44Z

estate/views/estate_property_views.xml

+                                <field name="garden_area"/>
+                                <field name="garden_orientation"/>
+                                <field name="state"/>
+                                <field name="total_area" readonly="1"/>


Is there any need to add readonly here?

No ma'am no need to add readonly because total_area is a compute method and compute method are by default readonly.

mash-odoo · 2026-01-12T12:39:13Z

estate/views/estate_property_views.xml

+                <field name="bedrooms"/>
+                <field name="living_area"/>
+                <field name="selling_price"/>
+                <filter string="Available Properties" name="available_properties" domain="[('state', 'in', ('new', 'offer_received'))]"/>


What are required params in the filter? How to add a default filter?

A filter requires a string, a unique name, and domain or a context. To apply a filter by default, we can use default="1" on the filter or set search_default_<filter_name> in the action context.

mash-odoo · 2026-01-12T12:43:21Z

estate/views/estate_property_type_views.xml

+                    <notebook>
+                        <page string="Properties">
+                            <field name="property_ids">
+                                <list>


What is the purpose of explicitly defining a list (tree) view here, even though the field is a One2many?
Won't it work just fine even if you write just this <field name="property_ids">?

mash-odoo · 2026-01-13T05:00:14Z

estate/models/estate_property.py

+    def action_sold(self):
+        for property in self:
+            if property.state == 'cancelled':
+                raise UserError("Sold property cannot be cancelled")


How can you make this translatable?

mash-odoo · 2026-01-13T05:01:30Z

estate/models/estate_property.py

+            property.state = 'cancelled'
+        return True
+
+    _check_expected_price_positive = models.Constraint(


Follow this conventions while declaring fields, constraints, methods or CRUD operations.

mash-odoo · 2026-01-13T10:16:28Z

estate/models/estate_property.py

+    )
+    property_type_id = fields.Many2one("estate.property.type", string="Property Type")
+    buyer_id = fields.Many2one("res.partner", string="Buyer", copy=False)
+    seller_id = fields.Many2one("res.users", string="Seller", default=lambda self: self.env.user)


What's the need to use this lambda function?

mash-odoo · 2026-01-16T11:02:57Z

estate/views/estate_property_views.xml

+                <header>
+                    <field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold"/>
+                </header>
+                <sheet>
+                    <header>
+                        <button name="action_sold" type="object" string="Sold" class="btn-primary" invisible="state in ('sold', 'cancelled')"/>
+                        <button name="action_cancel" type="object" string="Cancel" class="btn-secondary" invisible="state in ('sold', 'cancelled')"/>
+                    </header>


Suggested change

<header>

<field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold"/>

</header>

<sheet>

<header>

<button name="action_sold" type="object" string="Sold" class="btn-primary" invisible="state in ('sold', 'cancelled')"/>

<button name="action_cancel" type="object" string="Cancel" class="btn-secondary" invisible="state in ('sold', 'cancelled')"/>

</header>

<header>

<field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold"/>

<button name="action_sold" type="object" string="Sold" class="btn-primary" invisible="state in ('sold', 'cancelled')"/>

<button name="action_cancel" type="object" string="Cancel" class="btn-secondary" invisible="state in ('sold', 'cancelled')"/>

</header>

<sheet>

You can add these buttons directly in the header.

- Used Python inheritance to extend existing logic - Applied model inheritance to add fields and behavior - Used view inheritance to update and extend UI - Covers CHAPTER 12

jakan-odoo added 2 commits December 31, 2025 15:47

[ADD] estate: initialize module structure and model

71296e3

- Real Estate module created - Basic structure and required fields added - CHAPTER 1, 2, and 3

[ADD] estate: add security rules and fix style

3665d34

- Added basic security access for estate records - Fixed missing whitespace and formatting issues - Covers CHAPTER 4

jakan-odoo added 2 commits January 1, 2026 18:48

[ADD] estate: add basic user interface

d8791e0

- Added form and list views for estate records - Added menu and action to access the module - Covers CHAPTER 5

[IMP] estate: create basic views and search

378ed7c

- Added list, form, and search views - Added domains and group by options - Covers CHAPTER 6

mash-odoo requested changes Jan 2, 2026

View reviewed changes

jakan-odoo added 4 commits January 5, 2026 18:45

[IMP] estate: add many2one model relation

f155702

- Added Many2one relation between models - Improves data linking between records - Covers CHAPTER 7

[IMP] estate: add one2many and many2many relations

1c69bbe

- Added One2many and Many2many relations between models - Improves linking and management of related records - Covers CHAPTER 7

[IMP] estate: add computed fields and onchanges

9131c01

- Added computed fields for automatic values - Added onchange methods to update fields - Covers CHAPTER 8

[IMP] estate: implement object-based actions

2784e60

- Created Sell, Cancel, Accept, and Refuse buttons - Buttons call related methods on the estate models - Buyer and selling price are set when an offer is accepted - Covers CHAPTER 9

mash-odoo requested changes Jan 8, 2026

View reviewed changes

jakan-odoo added 5 commits January 8, 2026 18:34

[IMP] estate: add sql and python constraints

8c66cd9

- Added SQL constraints to ensure data validity - Added Python constraints for business rules - Covers CHAPTER 10

[IMP] estate: add inline views, widgets, and order

dbb059f

- Added inline views for related records - Applied widgets to improve user interface - Set default ordering using _order - CHAPTER 11

[IMP] estate: add property maintenance requests

aee8aeb

- Added maintenance request model with title, cost, and status - Ensured approved requests have a positive cost - Displayed total maintenance cost on the property - Prevented property sale when maintenance is not completed

[FIX] estate: improve maintenance cost validation

6dd7eec

- Replaced direct cost check with float_is_zero - Ensures correct validation for decimal precision

[IMP] estate: enhance views with UI improvements

ac29768

- Added manual ordering and widget options - Applied conditional button visibility using invisible - Made list views editable and some fields optional - Added decorations, default filters, and stat buttons - Covers CHAPTER 11

mash-odoo requested changes Jan 16, 2026

View reviewed changes

[IMP] estate: apply python, model, and view inheritance

54f03a6

- Used Python inheritance to extend existing logic - Applied model inheritance to add fields and behavior - Used view inheritance to update and extend UI - Covers CHAPTER 12

		from odoo import fields, models
		from dateutil.relativedelta import relativedelta

		<record id="estate_property_list_view" model="ir.ui.view">
		<field name="name">estate.property.list</field>

		<record id="estate_property_form_view" model="ir.ui.view">
		<field name="name">estate.property.form</field>

	'description': 'This module allows managing properties.',
	'description': "This module allows managing properties.",

		from dateutil.relativedelta import relativedelta
		from odoo import fields, models, api

19.0 real estate tutorial jakan #1109

Are you sure you want to change the base?

19.0 real estate tutorial jakan #1109

Uh oh!

Conversation

jakan-odoo commented Jan 1, 2026

Uh oh!

robodoo commented Jan 1, 2026

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants