19.0 tutorial dhvag #1110

dhvag-odoo · 2026-01-01T13:08:24Z

No description provided.

- Set up the estate module based on the Odoo 19 Server Framework 101 tutorial - Added estate.property model with proper naming conventions - Implemented basic fields as introduced in chapters 1–3 - Kept the code aligned with Odoo ORM standards

- Continued the estate module implementation by completing Chapters 4–6 - Added and configured views, actions, and menus to make the estate.property model fully accessible from the UI - Implemented list and form, views, filter, group-by - Added required defaults and the active field - Verified that all earlier checkpoints (Chapters 1–3) are still satisfied and working as expected - Overall implementation remains consistent with Odoo ORM guidelines and framework best practices

robodoo · 2026-01-01T13:08:27Z

…er 7) - Added relational fields (Many2one, One2many, Many2many) to the estate module - Linked properties with types, offers, tags, buyer, and salesperson - Created required views for managing offers within the property form - Updated access rights for new models

- Fixed the import issue in estate_property_offer file.

mash-odoo

Hello @dhvag-odoo,
Good work on the new module..
Please check my comments and apply the needed changes

estate/security/ir.model.access.csv

estate/views/estate_property_views.xml

estate/models/estate_property.py

estate/views/estate_menus.xml

estate/views/estate_property_views.xml

estate/security/ir.model.access.csv

- Applied the changes suggested during code review - Updated XML view structure and corrected attribute order - Cleaned up naming issues in views and filters - Adjusted default values and selection field keys - Removed unnecessary field strings in the model - Added new line in the file ir.model.access.csv

- This chapter introduces computed fields to derive values automatically. - Field dependencies are managed using the @api.depends decorator. - Onchange methods react to user input in real time on forms.

- Added accept and refuse actions for property offers - Handled the case where only one offer should be accepted - Updated property details like selling price and buyer when an offer is accepted - Learn to add python and SQL constraint

mash-odoo

Hello,
Good job on the PR!
Here are some few suggestions..

estate/models/estate_property.py

estate/__manifest__.py

estate/models/estate_property.py

estate/models/estate_property_offer.py

estate/views/estate_menus.xml

estate/views/estate_property_tag_views.xml

estate/views/estate_property_type_views.xml

estate/views/estate_property_views.xml

- Improve the look and behavior of form and list views. - Add status bar, decorations, and widgets for better clarity. - Control button visibility based on record state. - Set default sorting and make views more user-friendly. - Enhance search and display to make records easier to understand.

- Each request includes a title, cost, and status. - Validation added to ensure approved maintenance requests have a valid cost. - Total maintenance cost calculated. - Only done maintenance requests are to be sold.

mash-odoo

Hello!
Good work on the task..
Here are some suggestions..

mash-odoo · 2026-01-12T10:20:47Z

estate/models/estate_property_offer.py

+    def action_accept(self):
+        for record in self:
+            if record.property_id.state != 'offer_accepted':
+                record.status = 'accepted'
+                record.property_id.selling_price = record.price
+                record.property_id.buyer_ids = self.partner_id
+                record.property_id.state = 'offer_accepted'
+            else:
+                raise UserError('One offer has already been accepted')


Can you optimize this?

mash-odoo · 2026-01-12T10:21:31Z

estate/security/ir.model.access.csv

+access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1
+access_estate_property_tag,access_estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1
+access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1
+access_estate_property_maintenance_requests,access_estate_property_maintenance_requests,model_estate_property_maintenance_requests,base.group_user,1,1,1,1


Add a line at the end of file

mash-odoo · 2026-01-12T10:22:21Z

estate/views/estate_property_views.xml

+        <field name="name">estate.view.list</field>
+        <field name="model">estate.property</field>
+        <field name="arch" type="xml">
+            <list decoration-success="state == 'offer_received' or state == 'offer_accepted'" decoration-bf="state == 'offer_accepted'" decoration-muted="state == 'sold'">


Can we add decoration in form view?

mash-odoo · 2026-01-12T12:06:48Z

estate/views/estate_property_views.xml

+                <field name="living_area" string="living_area" filter_domain="[('living_area', '&gt;=', self)]"/>
+                <field name="facades"/>
+                <separator/>
+                <filter string="New / Offer Received" name="state" domain="['|',('state', '=', 'new'), ('state', '=', 'offer received')]"/>


What are required params in the filter? How to add a default filter?

mash-odoo · 2026-01-12T12:07:10Z

estate/views/estate_property_views.xml

+        <field name="name">Properties</field>
+        <field name="res_model">estate.property</field>
+        <field name="view_mode">list,form</field>
+        <field name="context">{'search_default_best_price': 0, 'search_default_state': 0}</field>


What does this 0 value indicate here?

mash-odoo · 2026-01-12T12:10:15Z

estate/views/estate_property_type_views.xml

+        <field name="arch" type="xml">
+            <list>
+                <field name="name"/>
+                <field name="sequence" widget="handle"/>


What does this widget do?

mash-odoo · 2026-01-12T12:14:30Z

estate/models/estate_property_type.py

+from odoo import api, fields, models
+
+
+class EstatePropertyType(models.Model):


Follow this conventions while declaring fields, constraints, methods or CRUD operations.

mash-odoo · 2026-01-12T12:27:37Z

estate/models/estate_property.py

+    property_type_id = fields.Many2one(
+        'estate.property.type', string="Property Type")
+    seller_ids = fields.Many2one(
+        'res.users', string="Salesman", default=lambda self: self.env.user


What does this lambda function do?

mash-odoo · 2026-01-16T09:24:12Z

estate/models/estate_property.py

+    )
+    property_type_id = fields.Many2one(
+        'estate.property.type', string="Property Type")
+    seller_ids = fields.Many2one(


Suggested change

seller_ids = fields.Many2one(

seller_id = fields.Many2one(

mash-odoo · 2026-01-16T09:56:09Z

estate/views/estate_property_views.xml

+                    <group>
+                        <group>
+                            <field name="tags_ids" widget="many2many_tags" options="{'color_field': 'color'}"/>
+                            <field name='state'/>


I don't think this is required here anymore as you are already adding this field in header as a statusbar

dhvag-odoo added 2 commits December 31, 2025 23:26

dhvag-odoo added 2 commits January 2, 2026 16:30

[FIX] estate module: fixed the import issue

41b6a55

- Fixed the import issue in estate_property_offer file.

mash-odoo requested changes Jan 2, 2026

View reviewed changes

dhvag-odoo added 3 commits January 3, 2026 23:47

[ADD] estate module: Computed Fields and Onchange (Chapter 8)

def4d3d

- This chapter introduces computed fields to derive values automatically. - Field dependencies are managed using the @api.depends decorator. - Onchange methods react to user input in real time on forms.

[ADD] estate module: Completed (Chapter 9 and 10)

fa2ac6b

- Added accept and refuse actions for property offers - Handled the case where only one offer should be accepted - Updated property details like selling price and buyer when an offer is accepted - Learn to add python and SQL constraint

mash-odoo requested changes Jan 8, 2026

View reviewed changes

dhvag-odoo added 2 commits January 9, 2026 19:13

[ADD] estate module: Completed Task: Property Maintenance Requests

332bd11

- Each request includes a title, cost, and status. - Validation added to ensure approved maintenance requests have a valid cost. - Total maintenance cost calculated. - Only done maintenance requests are to be sold.

mash-odoo requested changes Jan 16, 2026

View reviewed changes

		from odoo import api, fields, models


		class EstatePropertyType(models.Model):

19.0 tutorial dhvag #1110

Are you sure you want to change the base?

19.0 tutorial dhvag #1110

Uh oh!

Conversation

dhvag-odoo commented Jan 1, 2026

Uh oh!

robodoo commented Jan 1, 2026

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants