Fix crash on MW 1.43 #62 and some code clean up #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
malberts
reviewed
Aug 2, 2025
src/HooksHandler.php
Outdated
| } | ||
| foreach ( $this->getComponentLibrary()->getModulesFor( $activeComponent ) as $module ) { | ||
| $parser->getOutput()->addModuleStyles( $module, $skin ); | ||
| $parser->getOutput()->addModuleStyles( [ $module, $skin ] ); |
Collaborator
There was a problem hiding this comment.
Passing in $skin does not make sense. $skin does not refer to a module. I am not sure whether MW had a skin parameter long ago, or if something else was intended here, but this was already ignored in addModuleStyles( $module, $skin ) because the deprecated code used only the first parameter.
Contributor
Author
There was a problem hiding this comment.
The extension works without passing in $skin, but PHPUnit fails.
I don't know anything about PHPUnit.
Collaborator
There was a problem hiding this comment.
The tests are actually fine. The failures on REL1_43 and master are expected. It just seems like a test environment issue, but I wasn't able to fix it last time I looked (#59).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the call to addModuleStyles an array.