Angular gRPC#4
Open
webdevelopland wants to merge 2 commits into
Open
Conversation
oferb
requested changes
Aug 25, 2018
| //app/client:hello_world_service_js_binary | ||
|
|
||
| echo "Copying js binary" | ||
| rm -f app/client/app.js |
| responseType: hello_world_service_pb.HelloWorldResponse | ||
| }; | ||
|
|
||
| exports.HelloWorldService = HelloWorldService; |
Owner
There was a problem hiding this comment.
Did you modify any of the auto-generated files?
| @@ -0,0 +1,45 @@ | |||
| // package: com.google.startuposexample.app.localserver.service | |||
Owner
There was a problem hiding this comment.
Why do you need to add these files to the repo and not generate them in gulp?
What does npm run protoc do then?
Author
There was a problem hiding this comment.
My bad, I forgot to add the files to .gitignore
oferb
requested changes
Aug 25, 2018
| @@ -0,0 +1,23 @@ | |||
| #!/usr/bin/env bash | |||
Owner
There was a problem hiding this comment.
Let's remove run_sample.sh and keep only one example for Angular.
Author
There was a problem hiding this comment.
Should we delete app/client?
oferb
approved these changes
Oct 13, 2018
Owner
oferb
left a comment
oferb
left a comment
There was a problem hiding this comment.
Can you just double-check that it still works?
Author
|
Looks like gRPC localserver doesn't work anymore: |
GytisLaukaitis
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.