Draft
Conversation
- remove unused MailingListService+Model (move to backup-Folder) - move composer dependencies in module composer - refactoring of mail config key names - refactoring of MailService - move plugin specific methods of MailService to plugins (eg Insertion mails) - include plugin view folder in twig loader (untested yet)
added 2 commits
April 6, 2021 13:38
- change visibility of MailService::renderTemplate to public again (used in TestMail) - removed dummy/test files - replace old controller with new one (collect all endpoints) - refactor fixed mail-list to event driven data collection and add option for mail specific test data
skoletzko
approved these changes
Apr 7, 2021
Member
skoletzko
left a comment
skoletzko
left a comment
There was a problem hiding this comment.
Code review finished, but not tested yet.
Author
|
TODO: Move/split EventListener + Templates in (other) Modules/Plugins |
added 5 commits
April 19, 2021 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional repos: foaltohorse+orderprocess