fix: detect HANA database from S4CORE component in GetSystemInfo#100
Merged
oisee merged 1 commit intooisee:mainfrom Apr 12, 2026
Merged
fix: detect HANA database from S4CORE component in GetSystemInfo#100oisee merged 1 commit intooisee:mainfrom
oisee merged 1 commit intooisee:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect HANA database from S4CORE component
GetSystemInfocurrently relies on explicit HANA software components in theCVERStable. While this works for ECC on HANA, S/4HANA environments (like version 2022/757) often lack these specific components, causing the database to be reported incorrectly.Changes:
S4COREcomponent.DatabaseSystemasHDB.S4CORE, soDatabaseReleaseis left blank in this scenario.A path for a possible rework
Other approaches for system info retrieval (e.g., Marianfoo's ARC-1) may be worth analyzing for more comprehensive metadata in future patches.