Remove AutoMapper dependency and implement manual property mapping#37
Open
corpo-iwillspeak wants to merge 23 commits intoolegtarasov:masterfrom
Open
Remove AutoMapper dependency and implement manual property mapping#37corpo-iwillspeak wants to merge 23 commits intoolegtarasov:masterfrom
corpo-iwillspeak wants to merge 23 commits intoolegtarasov:masterfrom
Conversation
Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com> Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/4f8a1d14-bc20-46dc-974c-386441953c2d
…pendency Remove AutoMapper dependency
Author
|
This also solves half of your issues with #36 by removing the dependency. |
Author
|
@olegtarasov Apologies for the ping, but is there anything I can do to help move this along? |
Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/1b48ca3f-b1f8-4149-8de3-35cd1f5c4feb Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/3ab7d767-3d26-4149-bdf7-0a60df5a755d Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
…ferences Remove AutoMapper dependency from nuspec
Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/3b911b56-bca6-4835-8de4-1efb167fab6c Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
…ackage name Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/3b911b56-bca6-4835-8de4-1efb167fab6c Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
…ile write Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/3b911b56-bca6-4835-8de4-1efb167fab6c Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
…-automapper Remove AutoMapper dependency from nuspec
…PI key secret Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/e33d7de8-1098-4fb4-8342-d5bec1e045de Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
…lishing Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/1e170fc6-c3a2-4651-85a5-ab9e754e253f Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
…rked-libraries Switch to 2-stage CI/Publish workflow with MinVer versioning and NuGet trusted publishing
…step Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/fa02c9ff-8867-4616-929c-8d8f200cdd0f Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
…tion-issues Fix MinVer generating fallback version instead of tag-based version
Agent-Logs-Url: https://github.com/crispthinking/FastText.NetWrapper/sessions/fc8c6a29-df52-4028-9dcb-cf0a44d9de2c Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
[WIP] Reset master branch to commit 3d6f17b
Author
|
Forked version is published on Nuget.org as https://www.nuget.org/packages/CrispThinking.FastText.NetWrapper/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the presence of CVE-2026-32933 in AutoMapper and the more restrictive licensing of AutoMapper after 15.0 this PR removes the use of AutoMapper completely and replaces it with two dedicated mapping methods.
Open to suggestions here.
This pull request removes the dependency on AutoMapper from the
FastText.NetWrapperproject and replaces its usage with custom mapping methods. This change simplifies the codebase and reduces external dependencies. The referenced version of AutoMapper contains a vulnerability and later versions have moved to a restrictive license.Dependency removal:
FastText.NetWrapper.csprojand all relatedusing AutoMapper;statements from code files. [1] [2] [3]Code refactoring for argument mapping:
FastTextArgsand its derived classes with a newMapFromStructmethod for manual property assignment fromFastTextWrapper.FastTextArgsStruct. [1] [2] [3]FastTextArgsclass.FastTextWrapperclass constructor. [1] [2] [3]FastTextWrappermethods with new static mapping methodsToArgsStructandToAutotuneArgsStruct. [1] [2] [3] [4]