Skip to content

Lidar Safety Node Advanced#62

Open
nathanestill wants to merge 15 commits into
masterfrom
safe-lidar
Open

Lidar Safety Node Advanced#62
nathanestill wants to merge 15 commits into
masterfrom
safe-lidar

Conversation

@nathanestill
Copy link
Copy Markdown
Collaborator

I changed the code and made it nicer.

Copy link
Copy Markdown
Member

@ConnorNovak ConnorNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Function docstring comments
  • change "callback" to more specific - e.x. "lidar_cb"
  • Not running anything . . .
  • In run loop, check for "rospy.is_shutdown"
  • Also, throw in a section that waits until it gets lidar data to run main loop. Put in run function.
  • Last command in "if name == "main" should be calling run function.
  • Set up a rospy.Rate()
  • For var name and comments, reference base_link coordinate system
  • Draw and save quick diagram labeling geometries
    You're super cool though!

Copy link
Copy Markdown
Member

@ConnorNovak ConnorNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add downward-facing lidar and run some tests.

@ConnorNovak ConnorNovak changed the title LidarCodeAdvanced Lidar Safety Node Advanced Dec 7, 2018
Copy link
Copy Markdown
Member

@ConnorNovak ConnorNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Output twist messages that conform to the new state controller
  2. Register node as safety behavior by following instructions on wiki
  3. Implement some way to run with or w/o groundlidar
  4. Test with Amy's simulation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants