Images, colors, pdf export & more #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Ruckus T-Boom <uberawesomeemailaddressofdoom@gmail.com> Date: Tue Oct 17 12:35:18 2023 -0600
Replace deprecated navigation from:
customizing gestures
…e of selected color
…nts/Notable. Export to png or jpg is not working, but exeption is cought, and some messenge is shown. It is not perfect, but I'm happy with pdf
…obably messy solution to draw lines, but I have no better idea how to do it (now it generates 100 points for line)
…is shown on canvas, database changes ware not been checked, but propably work. images are sticky last image is rendered on every new page, do not know why
… are not hold in history, cannot enlarge image, code is nasty, but it works partially, good enough for now
Initial work on images
This reverts commit 1feec41.
This reverts commit 409b027.
This reverts commit 875abeb.
This reverts commit 7c886cf.
…eke " This reverts commit 73298a3.
apply all changes to main
- verified line-by-line that selectImage matches selectImagesAndStrokes - only difference: it also deselects any selected strokes, which is what we want
…to be pasted later
- also hide rescale-buttons unless exactly one image is selected
- requires Toolbar having access to the active EditorControlTower
…and strokes together
Moved isResizable to SelectionState. Moved resizeImage logic to SelectionState.
Cutting and Pasting between pages and notebooks
…c connected to selections.
Code cleanup: moved SelectionState to new file
…if toolbar is at the bottom.
Mostly back-end change, also improved style, and added work-in-progress switch for toolbar position.
Added a way to donate
- Prevented editor gesture detection when the window loses focus. - Prevented page view scrolling when delta is zero. - disable drawing mode when window loses focus.
Fix editor gesture handling and page view scrolling
* add roadmap and corrected table of contents and github sponsor as an option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
Sorry for not splitting this into smaller fixes, but I noticed there hasn't been much development on this repo, so I made improvements on my own to better fit my needs. I can confirm that it works on the Boox Note Air 4C running Android 13. I will periodically add changes and improvements to my fork, likely small adjustments to address things that annoy me while using the app (as with the changes mentioned above).