capture(wayland): fix black screen and pts timing on gst-launch#9
Open
domenkozar wants to merge 1 commit into
Open
capture(wayland): fix black screen and pts timing on gst-launch#9domenkozar wants to merge 1 commit into
domenkozar wants to merge 1 commit into
Conversation
domenkozar
force-pushed
the
go-gst-capture
branch
from
68dffbf to
8828f58
Compare
Author
|
@omarroth this is ready for review when you have a moment. It swaps the Verified end-to-end mirroring a niri desktop to a non-Apple AirPlay 2 receiver (Hisense), yuv420p, no crash. Happy to adjust anything. |
Keep the gst-launch CLI for the Wayland portal path, but fold in two fixes:
- vapostproc ! video/x-raw,format=I420 imports the portal's DMA-BUF via
VA-API (plain videoconvert fails to negotiate DMA-BUF on many drivers)
and forces 4:2:0 — RGB screens otherwise make x264enc emit "High 4:4:4
Predictive", which most receiver decoders reject (black screen).
- videorate drop-only=true skip-to-first=true ! framerate caps re-stamps
buffers onto a regular fps timeline; the portal can deliver pts=0, which
confuses encoder/muxer timing.
Verified end-to-end: mirrors a Wayland desktop to a non-Apple AirPlay 2
receiver (Hisense), yuv420p, no crash.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
domenkozar
force-pushed
the
go-gst-capture
branch
from
8828f58 to
c3c728f
Compare
domenkozar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the gst-launch CLI for the Wayland portal path, but fold in two fixes found while prototyping a go-gst version:
vapostproc ! video/x-raw,format=I420imports the portal's DMA-BUF via VA-API (plainvideoconvertfails to negotiate DMA-BUF on many drivers) and forces 4:2:0. RGB screens otherwise makex264encemit "High 4:4:4 Predictive", which most receiver decoders reject (black screen).videorate drop-only=true skip-to-first=true ! framerate capsre-stamps buffers onto a regular fps timeline; the portal can deliver pts=0, which confuses encoder/muxer timing.No new dependencies — the build stays pure Go (no CGO); GStreamer is still only invoked as the
gst-launch-1.0external binary.Verified end-to-end: mirrors a Wayland desktop to a non-Apple AirPlay 2 receiver (Hisense), yuv420p, no crash.