Handle infinities#7
Open
joshmoore wants to merge 8 commits into
Open
Conversation
joshmoore
added a commit
to joshmoore/omero-blitz
that referenced
this pull request
Dec 17, 2019
If an input is an infinity, then do not perform the conversion. see: - ome/ome-units#7 - ome/omero-gateway-java#15 (comment)
dominikl
reviewed
Dec 17, 2019
Member
dominikl
left a comment
dominikl
left a comment
There was a problem hiding this comment.
So if input is infinite then simply return infinite again? Looks alright 👍
Member
Author
|
@dominikl : do you have a straight-forward method for testing |
Member
|
Not really. There was an image with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see ome/omero-gateway-java#15 (comment)
also includes a general refresh of this repository to match 5.5+ (decoupling, code changes)