Fixed broken testArraySearch() test

[jdevinemt]

testArraySearch() test in StringToNumberComparisonTest class did not assert correct behavior. It was asserting that the custom arraySearch() function would return a value "equal" to 0, which uses loose equality. Therefore, when running the test in PHP 8.0+ it falsely passes because arraySearch() returns false, which is "equal" to 0. The test was updated to assert that the return value was exactly 0.

[jayay]

Good catch! This test was extracted from one of our internal tests, where $this->assertEquals() behaves like $this->assertSame() in PHPUnit. So that might have been forgotten.

Replacing every assertEquals() with assertSame() should still give us a working test. Would you consider trying that out?

[jdevinemt]

Good catch! This test was extracted from one of our internal tests, where $this->assertEquals() behaves like $this->assertSame() in PHPUnit. So that might have been forgotten.

Replacing every assertEquals() with assertSame() should still give us a working test. Would you consider trying that out?

I replaced all usage of assertEquals() with assertSame() in test suite and verified tests still work as expected. There was one additional test class that was using assertEquals(), it was not affecting test behavior, but I updated it to be consistent with the usage of assertSame() throughout the rest of the test suite.

I also fixed a deprecation warning I was getting when running tests.

[jayay]

I replaced all usage of assertEquals() with assertSame() in test suite and verified tests still work as expected. There was one additional test class that was using assertEquals(), it was not affecting test behavior, but I updated it to be consistent with the usage of assertSame() throughout the rest of the test suite.

I also fixed a deprecation warning I was getting when running tests.

Awesome, thank you! 😊