Skip to content

feat: ✨ convert REDCap dictionary to resource properties#35

Merged
lwjohnst86 merged 13 commits intomainfrom
feat/convert-to-resources
Apr 7, 2026
Merged

feat: ✨ convert REDCap dictionary to resource properties#35
lwjohnst86 merged 13 commits intomainfrom
feat/convert-to-resources

Conversation

@martonvago
Copy link
Copy Markdown
Collaborator

@martonvago martonvago commented Mar 20, 2026

Description

This PR adds the ability to convert a saved REDCap data dict to resource properties.
Followed this plan: #23 (comment)
Does not include a resource for events/visits. Not sure if we want that?

Closes #25 closes #26

This PR needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@martonvago martonvago moved this from Todo to In Review in Data development Mar 20, 2026
@martonvago martonvago marked this pull request as ready for review March 20, 2026 11:56
Copy link
Copy Markdown
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start! It would be better to actually see what the properties output is though.

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Data development Mar 25, 2026
@martonvago
Copy link
Copy Markdown
Collaborator Author

I added the generated resource properties to the package properties and updated main.py. Then I ran main.py on GenomeDK and committed the generated datapackage.json.

@martonvago martonvago moved this from In Progress to In Review in Data development Mar 25, 2026
@martonvago martonvago requested a review from lwjohnst86 March 25, 2026 14:04
Copy link
Copy Markdown
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Data development Apr 7, 2026
@lwjohnst86 lwjohnst86 changed the title feat: ✨ convert redcap data dict to resource properties feat: ✨ convert REDCap dictionary to resource properties Apr 7, 2026
@lwjohnst86 lwjohnst86 merged commit 8a0bc24 into main Apr 7, 2026
@lwjohnst86 lwjohnst86 deleted the feat/convert-to-resources branch April 7, 2026 07:40
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data development Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Convert data dictionary items within each resource into properties Reproducibly split data dictionary into resources

3 participants