Skip to content

fix(release): drop blank gap before direct-push commits#23

Merged
BlackHole1 merged 1 commit into
mainfrom
fix-release-not
Jun 15, 2026
Merged

fix(release): drop blank gap before direct-push commits#23
BlackHole1 merged 1 commit into
mainfrom
fix-release-not

Conversation

@BlackHole1

Copy link
Copy Markdown
Member

GitHub's generate-notes leaves a blank-line run before the trailing "Full Changelog" line. The awk that splices direct-push commits in ran after those blanks were already printed, so the commits landed below the gap with another blank added after them — producing a multi-line hole between the PR list and the direct-push commits in both the Release page and the Sparkle update window.

Buffer blank lines instead of printing them as they arrive: at the splice point, drop the buffered run, emit the commits flush against the last PR bullet, then exactly one blank line before the section. Blank runs elsewhere are flushed verbatim, so only the pre-splice gap is normalized.

GitHub's generate-notes leaves a blank-line run before the trailing
"Full Changelog" line. The awk that splices direct-push commits in
ran after those blanks were already printed, so the commits landed
below the gap with another blank added after them — producing a
multi-line hole between the PR list and the direct-push commits in
both the Release page and the Sparkle update window.

Buffer blank lines instead of printing them as they arrive: at the
splice point, drop the buffered run, emit the commits flush against
the last PR bullet, then exactly one blank line before the section.
Blank runs elsewhere are flushed verbatim, so only the pre-splice
gap is normalized.

Signed-off-by: Kevin Cui <bh@bugs.cc>
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f2c59893-365e-4baf-acea-7355b0db9840

📥 Commits

Reviewing files that changed from the base of the PR and between 6a74a92 and 18fc2d0.

📒 Files selected for processing (1)
  • .github/workflows/build-publish.yml

Summary by CodeRabbit

  • Chores
    • Improved release notes generation formatting to ensure proper spacing and positioning of commit entries between sections for enhanced readability and consistency.

Walkthrough

The inline awk program within the "Generate release notes (single source for appcast + Release)" workflow step is rewritten to buffer contiguous blank lines instead of emitting them immediately. The new logic delays blank-line output until after direct-push commit bullets from direct-commits.md are spliced in, preventing a stray blank line from appearing above the inserted commits. A single blank line is then emitted before the subsequent "New Contributors" or "Full Changelog" section. An END rule handles flushing any remaining buffered state.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format with type and scope, and clearly describes the main fix of normalizing blank lines before direct-push commits in release notes.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem with blank lines in release notes and how the awk logic fix addresses it.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix-release-not

Comment @coderabbitai help to get the list of available commands and usage tips.

@BlackHole1 BlackHole1 merged commit c72fcc5 into main Jun 15, 2026
3 checks passed
@BlackHole1 BlackHole1 deleted the fix-release-not branch June 15, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant