Fix memory leak of SecTask
#9
Open
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a memory leak in the `getProcessExtensions` function where the `SecTask` object created by `SecTaskCreateWithAuditToken` was never released. ### Changes: - Added null check after creating `secTask` for safety - Added `CFRelease(secTask)` after retrieving the signing identifier to properly release the CoreFoundation object - Added early return if `secTask` creation fails ### Testing: The changes follow CoreFoundation memory management rules where objects returned by Create functions must be released manually.
There was a problem hiding this comment.
Pull request overview
This PR fixes a memory leak in the getProcessExtensions function where the SecTask object created by SecTaskCreateWithAuditToken was never released, violating CoreFoundation's memory management rules for objects returned by Create functions.
Changes:
- Added null check and early return if
SecTaskcreation fails - Added
CFRelease(secTask)to properly release the CoreFoundation object after use
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in the
getProcessExtensionsfunction where theSecTaskobject created bySecTaskCreateWithAuditTokenwas never released.Changes:
secTaskfor safetyCFRelease(secTask)after retrieving the signing identifier to properly release the CoreFoundation objectsecTaskcreation failsTesting:
The changes follow CoreFoundation memory management rules where objects returned by Create functions must be released manually.