Add blog post on architecture and framework integration#106
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request adds a new MDX blog post documenting Formisch's architecture: a four-function reactive contract ( 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a new architecture-focused blog post and introduces a dedicated layout for rendering individual blog posts with consistent meta/cover rendering and an “Edit page” link.
Changes:
- Added a new MDX blog post: “One core, six frameworks, zero runtime abstraction”.
- Introduced a
(posts)route layout to render post title/meta/cover, post content, and credits. - Added an “Edit page” button for blog posts that links to the post source on GitHub.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/src/routes/blog/(posts)/one-core-six-frameworks/index.mdx | New blog post describing Formisch’s build-time framework integration approach. |
| website/src/routes/blog/(posts)/layout.tsx | New layout component for blog post pages (title/meta/cover + content + edit link + credits). |
Comments suppressed due to low confidence (1)
website/src/routes/blog/(posts)/one-core-six-frameworks/index.mdx:51
- This section says "Here are four of them, in full", but the linked adapter files include additional exports/implementation (e.g.
framework,createId,batch,untrack). Either include the full adapter contents or adjust the wording to clarify these snippets are partial (e.g. showing only thecreateSignalpart).
Because most modern frameworks already have a signal primitive that fits the `.value` getter/setter shape, most of the adapters are nearly invisible. Here are four of them, in full:
**Vue** ([`index.vue.ts`](https://github.com/open-circle/formisch/blob/main/packages/core/src/framework/index.vue.ts)):
```ts
export { shallowRef as createSignal } from 'vue';
</details>
---
💡 <a href="/open-circle/formisch/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
…ations and adapter invisibility
|
Three Copilot items addressed in cdce793:
Bonus self-caught fix: line 41 originally said "No `if (framework === 'solid')` anywhere in the source", which is literally false (`initializeFieldStore.ts` has `framework === 'qwik' && schema.type === 'lazy'` for the Qwik feature gate). Reworded to focus on what's actually true: no runtime detection. |
Summary by cubic
Added the blog post “One core, six frameworks, zero runtime abstraction,” clarifying the build-time reactivity swap with concrete adapter snippets, improved links, updated publish date, and final formatting.
Standardized wording across the React/Vue/Svelte/Solid/Preact/Qwik architecture guides for clarity, and renamed the blog posts layout route to fit the new structure (no functional changes).
Written for commit bd9d5de. Summary will update on new commits. Review in cubic