Skip to content

Apply auditing to entity Pedido and Renglon Pedido#465

Open
k31kur0n0 wants to merge 36 commits into
masterfrom
issue442JaVers
Open

Apply auditing to entity Pedido and Renglon Pedido#465
k31kur0n0 wants to merge 36 commits into
masterfrom
issue442JaVers

Conversation

@k31kur0n0
Copy link
Copy Markdown
Member

No description provided.

@k31kur0n0 k31kur0n0 self-assigned this Apr 27, 2023
@k31kur0n0 k31kur0n0 linked an issue May 12, 2023 that may be closed by this pull request
Comment thread pom.xml Outdated
Comment thread pom.xml
Comment thread src/main/java/sic/controller/PedidoController.java Outdated
Comment thread src/main/java/sic/controller/PedidoController.java Outdated
Comment thread src/main/java/sic/controller/PedidoController.java Outdated
Comment thread src/main/java/sic/modelo/dto/CambioDTO.java Outdated
Comment thread src/main/java/sic/modelo/dto/CommitDTO.java Outdated
Comment thread src/main/java/sic/service/IAuthService.java Outdated
Comment thread src/main/java/sic/service/impl/AuthServiceImpl.java Outdated
Comment thread src/main/java/sic/service/impl/JaversServiceImpl.java Outdated
Comment thread src/main/java/sic/service/impl/JaversServiceImpl.java Outdated
Comment thread src/main/java/sic/controller/PedidoController.java Outdated
Comment thread src/main/java/sic/controller/PedidoController.java Outdated
Comment thread src/main/java/sic/service/impl/PedidoServiceImpl.java Outdated
Comment thread src/main/java/sic/service/impl/JaversServiceImpl.java Outdated
Comment thread src/main/java/sic/config/AppConfig.java Outdated
Comment thread src/main/java/sic/service/impl/JaversAuditServiceImpl.java Outdated
Comment thread src/main/java/sic/service/IAuditService.java Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

59.9% 59.9% Coverage
0.0% 0.0% Duplication

@open-commercial open-commercial deleted a comment from sonarqubecloud Bot Jul 3, 2023
@belluccifranco
Copy link
Copy Markdown
Member

  • En el JSON de respuesta: al atributo usuario agregar un espacio en blanco antes del primer parentesis para separar bien el nombre del username
  • Al dar de alta un Pedido con 3 renglones y pedir sus renglones con el endpoint /pedidos/{id}/renglones/cambios solo retorna 1 de ellos
    image
  • En la respuesta del endpoint de renglones, eliminar un nivel de anidamiento, de tal manera que quede igual al endpoint de cambios de Pedido

@belluccifranco belluccifranco self-requested a review July 10, 2023 18:43
Copy link
Copy Markdown
Member

@belluccifranco belluccifranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ver comentarios

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

83.0% 83.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

83.0% 83.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
83.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply auditing to entity Pedido and Renglon Pedido

2 participants