feat: close persistent references held on a context#1923
Open
Skarlso wants to merge 1 commit intoopen-component-model:mainfrom
Open
feat: close persistent references held on a context#1923Skarlso wants to merge 1 commit intoopen-component-model:mainfrom
Skarlso wants to merge 1 commit intoopen-component-model:mainfrom
Conversation
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
github-actions
Bot
added
kind/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Closes dangling context references. All allocations are done all the time and finalizers don't truly close references. This means that everytime a context is created the ref is basically never cleaned up. This leads to the memory leak observed in the attached issue. This close will be called in the controller explicitly.
Which issue(s) this PR is related to
Related to open-component-model/ocm-project#778.