Skip to content

chore(bdba): Properly log response object in case of errors #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8R0WNI3 merged 1 commit into from
Jun 22, 2026
+5 −1
Merged

chore(bdba): Properly log response object in case of errors #866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/bdba/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,12 @@ def increment(
retry = super().increment(method, url, response, error, _pool, _stacktrace)
# Use the Retry history to determine the number of retries.
num_retries = len(self.history) if self.history else 0
status = response.status if response else None
reason = response.reason if response else None
content = response.data.decode() if response else None
logger.warning(
f'{method=} {url=} returned {response=} {error=} {num_retries=} - trying again',
f'{method=} {url=} returned {status=} {reason=} {error=} {num_retries=} - trying again '
f'({content=})',
)
return retry

Expand Down
Loading