Skip to content

fix(packages): Pin odg-core-libs version during image build#870

Merged
8R0WNI3 merged 1 commit into
open-component-model:masterfrom
8R0WNI3:master
Jun 23, 2026
Merged

fix(packages): Pin odg-core-libs version during image build#870
8R0WNI3 merged 1 commit into
open-component-model:masterfrom
8R0WNI3:master

Conversation

@8R0WNI3

@8R0WNI3 8R0WNI3 commented Jun 23, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:
Since the package is also published to PyPI, it must be ensured that the version of the current build (e.g. a hotfix version) is used instead of the greatest available version (e.g. from PyPI).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `odg-core-libs` version is now pinned during the image build

Since the package is also published to PyPI, it must be ensured that the
version of the current build (e.g. a hotfix version) is used instead of
the greatest available version (e.g. from PyPI).

Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
@8R0WNI3 8R0WNI3 self-assigned this Jun 23, 2026
@8R0WNI3 8R0WNI3 added the kind/bugfix Bug label Jun 23, 2026
@8R0WNI3 8R0WNI3 requested a review from a team as a code owner June 23, 2026 11:45
@8R0WNI3 8R0WNI3 added area/ipcei Important Project of Common European Interest area/cicd Continuous Integration and Continuous Deployment related labels Jun 23, 2026
@github-project-automation github-project-automation Bot moved this to 🔦 Needs Triage in Open Delivery Gear Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9b4d19a3-30e6-41f4-9f1b-e65229c71ea1

📥 Commits

Reviewing files that changed from the base of the PR and between ad1bf21 and fa2352c.

📒 Files selected for processing (2)
  • .github/workflows/build.yaml
  • Dockerfile

📝 Walkthrough

Walkthrough

The CI workflow exports the computed package version from the packages job as a step output and job-level output, then passes it as ODG_CORE_LIBS_VERSION build arg to the oci-image job. The Dockerfile declares that build arg and uses it to pin the odg-core-libs install to the exact computed version.

Changes

Version propagation from CI to OCI image build

Layer / File(s) Summary
CI version output and job wiring
.github/workflows/build.yaml
The distribution-packages step receives id: packages and writes version=${version} to GITHUB_OUTPUT; the packages job declares a version output mapped from that step; the oci-image job sets ODG_CORE_LIBS_VERSION in build-args from needs.packages.outputs.version.
Dockerfile build arg and pinned install
Dockerfile
Adds ARG ODG_CORE_LIBS_VERSION and changes the pip3 install invocation from an unpinned odg-core-libs to odg-core-libs==${ODG_CORE_LIBS_VERSION}.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

A rabbit hopped through the pipeline one day,
"Which version of libs?" she heard someone say.
She wrote to the output, pinned it down tight,
Passed it to Docker — the version just right.
No more floating installs to cause a fright! 🐇📦

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: pinning the odg-core-libs version during image build, which matches the core objective of the PR.
Description check ✅ Passed The description includes all required sections from the template with appropriate content: problem statement, issue reference field, reviewer notes field, and a properly formatted release note.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@8R0WNI3 8R0WNI3 moved this from 🔦 Needs Triage to 🔍 Review in Open Delivery Gear Jun 23, 2026

@zkdev zkdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@8R0WNI3 8R0WNI3 merged commit 53189e5 into open-component-model:master Jun 23, 2026
15 of 17 checks passed
@github-project-automation github-project-automation Bot moved this from 🔍 Review to 🍺 Done in Open Delivery Gear Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cicd Continuous Integration and Continuous Deployment related area/ipcei Important Project of Common European Interest kind/bugfix Bug

Projects

Status: 🍺 Done

Development

Successfully merging this pull request may close these issues.

2 participants