Skip to content

refactor(asset-to-owner): Use more user centric error messages#872

Merged
zkdev merged 1 commit into
open-component-model:masterfrom
zkdev:user-centric-msg
Jun 23, 2026
Merged

refactor(asset-to-owner): Use more user centric error messages#872
zkdev merged 1 commit into
open-component-model:masterfrom
zkdev:user-centric-msg

Conversation

@zkdev

@zkdev zkdev commented Jun 23, 2026

Copy link
Copy Markdown
Member

This error is end-user facing.
Let's be less technical and drop details.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

If automatic issue assignment fails, there is now a more meaningful and user friendly message added as comment.

This error is end-user facing.
Let's be less technical and drop details.

Signed-off-by: Philipp Heil (zkdev) <philipp.heil@sap.com>
@zkdev zkdev requested a review from a team as a code owner June 23, 2026 13:25
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 75ecb399-f1d0-4ed2-b1cd-0c2a372ebe06

📥 Commits

Reviewing files that changed from the base of the PR and between 53189e5 and 73196ec.

📒 Files selected for processing (2)
  • src/components.py
  • src/issue_replicator/github.py

📝 Walkthrough

Walkthrough

Two user-facing error/status message strings are updated. In ComponentResponsibles.get, the message for the user_identities is None case is replaced with text describing a GitHub limitation and instructions for manual assignment. In create_issue, the introductory sentence and markdown table headers for the assignment-problems comment are renamed from Message Type/Message to Status/Details.

Changes

Assignee Error Message Text Updates

Layer / File(s) Summary
Updated assignee status/error message text
src/components.py, src/issue_replicator/github.py
ComponentResponsibles.get replaces the heuristic/incomplete-statistics error message with a GitHub-limitation description and manual assignment guidance. create_issue updates the assignment-problems comment intro sentence and renames markdown table columns from Message Type/Message to Status/Details.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hopped in, quill in paw,
Found some old messages full of flaw.
"Status and Details," the new headers say,
"GitHub's to blame — assign manually today!"
Clearer words now light the way. 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: making error messages more user-centric in the asset-to-owner component.
Description check ✅ Passed The description includes most required sections with relevant details about the change and release notes, though the 'What this PR does' section is incomplete.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zkdev zkdev self-assigned this Jun 23, 2026
@zkdev zkdev added kind/refactor refactoring, maintenance, etc. area/ipcei Important Project of Common European Interest labels Jun 23, 2026
@github-project-automation github-project-automation Bot moved this to 🔦 Needs Triage in Open Delivery Gear Jun 23, 2026
@zkdev zkdev moved this from 🔦 Needs Triage to 🔍 Review in Open Delivery Gear Jun 23, 2026

@8R0WNI3 8R0WNI3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adenitiu adenitiu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zkdev zkdev merged commit 08ce125 into open-component-model:master Jun 23, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from 🔍 Review to 🍺 Done in Open Delivery Gear Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipcei Important Project of Common European Interest kind/refactor refactoring, maintenance, etc.

Projects

Status: 🍺 Done

Development

Successfully merging this pull request may close these issues.

3 participants