Skip to content

Parse TransmitterPdu modulation parameters and variable transmitter parameters #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leif81 merged 18 commits into from
Oct 3, 2025
Merged

Parse TransmitterPdu modulation parameters and variable transmitter parameters #79

leif81 merged 18 commits into from
Oct 3, 2025

Conversation

@ngjunsiang
Copy link
Contributor

@ngjunsiang ngjunsiang commented Oct 2, 2025

This PR implements:

  • Parsing of modulation parameters for Generic Radio, Simple Intercom Radio, HAVE QUICK radio, CCTT SINCGARS radio from Annex C
  • Parsing of variable transmitter parameters for HAVE QUICK radio (high fidelity)
  • Parsing of Beam Antenna pattern
  • fallback to Unknown record types for the above

QoL improvements:

  • bitfield moved to its own module under the record namespace

@ngjunsiang
refactor: separate bitfield type into bitfield.py
2a70a4d
@ngjunsiang
refactor: separate bitfield type into bitfield.py
33517f2
@ngjunsiang
chore: remove unused ModulationParameters class
ef3bd3b
@ngjunsiang
refactor: explicitly define ModulationParametersRecord and AntennaPat…
db60ac0 
…ternRecord as abstract base classes

In Python, this means these classes cannot be instantiated on their own.
Subclasses are expected to provide concrete implementations of the abstract base class.
@ngjunsiang
docs: update docstrings
1e7dad2
@ngjunsiang
refactor: migrate EulerAngles and BeamAntennaPattern classes to recor…
4308ab7 
…d namespace
@ngjunsiang
feat: handle BeamAntennaPattern parsing in TransmitterPdu
4ff3217
@ngjunsiang
docs: update docstrings
f62039e
@ngjunsiang
docs: remove unnecessary docstrings
748d65c
@ngjunsiang
chore: update imports, replace VariableTransmitterParameters in dis7.py
618bb78
@ngjunsiang
feat: add CCTTSincgarsMP record class
63c925d
@ngjunsiang
feat: parse modulation parameters for GenericRadio, SimpleIntercomRad…
c8e137b 
…io, HAVE QUICK radios, CCTT Sincgars radios
@ngjunsiang
feat: parse variable transmitter parameters for High Fidelity HAVE QU…
88b75f2 
…ICK radios
@ngjunsiang
fix: fix type annotation for variableTransmitterParameters
f14ac0b
@ngjunsiang
fix: fix imports
97358b6
@ngjunsiang
refactor: move bitfield under record namespace
418f50e
@ngjunsiang
Merge pull request #1 from ngjunsiang/feat-record-class
2e44316 
Parse TransmitterPdu modulation parameters and variable transmitter parameters
@ngjunsiang ngjunsiang mentioned this pull request Oct 2, 2025
Open
@leif81 leif81 merged commit af61f14 into open-dis:master Oct 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leif81 leif81 leif81 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ngjunsiang @leif81