Handle Damage Description records #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface This helps to enforce a consistent interface across all Record subclasses with the help of a static checker
…ableRecord classes The mapping from recordType enum values to VariableRecord classes is defined in [UID 66]. Instead of scattering information about this mapping throughout the codebase or dis7.py, it would be more readable to concentrate it in this getter function.
Not yet working due to null() calls
Standard Variable (SV) records have recordType and recordLength properties
subclasses must call superclass serialize() and parse() methods
Handle Damage Description records
Member
|
Thank-you @ngjunsiang I overlooked this earlier. I'll take a look. |
Member
|
@ngjunsiang Thank-you for this significant change Notable to also mention EntityID is changing to EntityIdentifier here. Let merge. |
leif81
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chipping away at #14. As a bonus,
DirectedEnergyFirePduandEntityDamageStatusPduare now fixed.Changelog
This PR adds damage description records used by the warfare protocol family PDUs:
Also added is a
symbolic_names.pyfile containing names and constant/variable values, from Table 25. These are not used yet, but may be required later when implementing the logic required for parsing or serializing some classes. Prep work for #58A few record types that the above were dependent on were also migrated to the
recordnamespace, as part of a larger migration.QoL improvements
Record(fixed length),VariableRecord(variable length),StandardVariableRecord(variable length with a recordType and recordLength, following 6.2.83)getStandardVariableRecord()andparseStandardVariableRecord()helper functionsgetStandardVariableRecord()takes a recordType and returns the appropriate record classparseStandardVariableRecord()takes aDataInputStreamand a recordType, and returns a fully parsed SV Recordrecordnamespace organized into sub-namespaces following protocol families. Classes are organized alphabetically by chapter number following IEEE1278.1-2012 for ease of lookup, with any base classes defined first.