Modify setup_common to match new nx2elf#45
Open
LynxDev2 wants to merge 1 commit into
Open
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Around a year ago https://github.com/MonsterDruide1/nx2elf/ was changed so that instead of the ELF and uncompressed NSO ending up next to the input NSO, the output paths for those two files now needed to be manually specified. This has two benefits:
So this PR changes
_convert_nso_to_elfaccordingly to support the latestnx2elf.nx-decomp-tools-binariesneeds to be updated separately in a later PR for projects like botw to be able to update to this versionThis change is