Skip to content

Add method for SemVer check #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aacuevas wants to merge 1 commit into from
Closed

Add method for SemVer check #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions Source/devices/oni/AcqBoardONI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,8 @@ bool AcqBoardONI::detectBoard()
{
LOGC ("Open Ephys ECP5-ONI FPGA open. Gateware version v", major, ".", minor, ".", patch);
}
hasI2cSupport = major >= 1 && minor >= 5;
hasMemoryMonitorSupport = major >= 1 && minor >= 5 && patch >= 1;
hasI2cSupport = CheckSemVer (major, minor, patch, 1, 5, 0);
hasMemoryMonitorSupport = CheckSemVer (major, minor, patch, 1, 5, 1);

if (major == 0)
{
Expand Down Expand Up @@ -2177,3 +2177,21 @@ bool AcqBoardONI::getMemoryMonitorSupport() const
{
return hasMemoryMonitorSupport;
}

bool AcqBoardONI::CheckSemVer (int major, int minor, int patch, int targetMajor, int targetMinor, int targetPatch)
{
if (major > targetMajor)
return true;
else if (major < targetMajor)
return false;

if (minor > targetMinor)
return true;
else if (minor < targetMinor)
return false;

if(patch >= targetPatch)
return true;

return false;
}
2 changes: 2 additions & 0 deletions Source/devices/oni/AcqBoardONI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,8 @@ class AcqBoardONI : public AcquisitionBoard

DataBuffer* memBuffer = nullptr;
Array<DataBuffer*, juce::DummyCriticalSection, NUMBER_OF_PORTS> bnoBuffers;

static bool CheckSemVer (int major, int minor, int patch, int targetMajor, int targetMinor, int targetPatch);
};

#endif
Loading