Add liboni as submodule#54
Closed
bparks13 wants to merge 12 commits into
Closed
Conversation
- CMakeLists now checks if Linux or Apple before installing the driver, as that is the only portion that is unique between the two environments
- Changes to the ft600 driver require new FTDI drivers installed, as well as a firmware update on the hardware
- Ensure that the ReleaseStatic configuration is respected for liboni, and point to the correct folder to grab the driver DLL
- Ensure that the built files are copied to a common location so that the Actions can easily find and save the appropriate files
Collaborator
|
Included in #55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we remove the precompiled files, and instead link liboni as a submodule. We also modified the cmake commands to build liboni and the libonidriver_ft600 on each of the environments we use (Windows, Linux, MacOS).
The commit that the submodule points to includes new changes made to the ft600 driver that improve performance on Linux.
This version is a major version increase due to the ft600 driver updates, as this requires new FTDI drivers to be installed, and also requires a new version of the firmware on the acquisition board itself.