Skip to content

Introduce storage_optimize_copy GUC #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reshke merged 2 commits into from
Mar 25, 2026
Merged

Introduce storage_optimize_copy GUC #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7f339f
Introduce `storage_optimize_copy` GUC
reshke Mar 24, 2026
dbcdefd
toggle logic to log everything
reshke Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ type Storage struct {

StorageRegion string `json:"storage_region" toml:"storage_region" yaml:"storage_region"`

// copy behaviour control option
StorageOptimizeCopy bool `json:"storage_optimize_copy" toml:"storage_optimize_copy" yaml:"storage_optimize_copy"`

// File storage default s3. Available: s3, fs
StorageType string `json:"storage_type" toml:"storage_type" yaml:"storage_type"`

Expand Down
9 changes: 7 additions & 2 deletions pkg/proc/interaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,9 +911,14 @@ func ListFilesToCopy(prefix string, port uint64, cfg config.Storage, src storage
path := strings.TrimPrefix(objectMetas[i].Path, cfg.StoragePrefix)
reworked := path
if _, ok := vi[reworked]; !ok {
ylogger.Zero.Info().Int("index", i).Str("object path", objectMetas[i].Path).Msg("not in virtual index, skipping...")
skipCopy := config.InstanceConfig().StorageCnf.StorageOptimizeCopy
skipped = append(skipped, objectMetas[i])
Copy link
Copy Markdown

@vovik0134 vovik0134 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok that some objects are present in both lists (skipped and toCopy) when StorageOptimizeCopy=false?

Copy link
Copy Markdown
Contributor Author

@reshke reshke Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this list is for verbosity purposes, actual user (ProcessCopyExtended) ignores this.

continue

ylogger.Zero.Info().Int("index", i).Str("reworked name", reworked).Str("object path", objectMetas[i].Path).Bool("skipping", skipCopy).Msg("not in virtual index")

if skipCopy {
continue
}
}
if sz, ok := copiedSizes[objectMetas[i].Path]; ok {
ylogger.Zero.Info().
Expand Down
Loading