feat: Lab Format Generators, Flowsheet Enhancements, Security Fixes, and DevOps Improvements#185
Merged
Merged
Conversation
…c into a dedicated utility class CMLLabHL7Generator.
…o a dedicated utility class MDSLabHL7Generator. This continues the modularization of lab format generation. Changes: - Add MDSLabHL7Generator with comprehensive MDS-specific segment building - Implement buildMSH(), buildZLB(), buildZRG(), buildZMNSegments(), buildZCLSegments() - Implement buildPID(), buildPV1(), buildZFR(), buildZCT(), buildTestSegments(), buildZPD() - Add normalizeAccession() for MDS-specific accession format handling - Add parseCCDoctor() with support for multiple CC doctor formats - Add buildMDSReferenceRange() for MDS-specific reference range formatting - Update SubmitLabByForm2Action to route MDS lab types to MDSLabHL7Generator - Preserve all critical comments about MDS format requirements
…nto the session and accesses the page
…teException possibility
…rating it into SubmitLabByForm2Action. GDMLLabHL7Generator features: - MSH segment with GDML-specific message header format - PID segment with correct field mapping (HIN in PID-2, accession in PID-3) - ZDR segments for CC doctor parsing and name component extraction - OBR segment with XCN format for ordering provider (billing number, name) - OBX segments with GDML reference range format (low-high^formatted text) - Value type normalization (converts FT to ST for proper display) - NTE segment support for test-specific notes SubmitLabByForm2Action changes: - Import GDMLLabHL7Generator utility class - Add GDML routing logic in generateHL7() method alongside MDS and CML
…red-audit-log-1592
…encoding-error-pages-1196
- Add class-level JavaDoc with healthcare context explaining INR monitoring - Add @SInCE tag with 2026-01-14 date from git history - Add @see tags for related classes (FrmRecord, FrmRecordHelp, FrmData) - Document all 7 public methods with @param, @return, and @throws tags - Include healthcare domain context for BC anticoagulation therapy - Explain HL7 integration and provincial lab system connectivity Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>
Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>
…ethods Co-authored-by: yingbull <8680161+yingbull@users.noreply.github.com>
…00d58408ad738c1b9203b3be7701b9cd72e98'
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…graphicDataAction42Action.java Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
feat: add additional foundational config for futher UI tests
docs: add comprehensive JavaDoc to AbstractModel.java
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…attachments Resolve demographic import with ZIP attachments
- Fix Bootstrap version references (5.0.2 -> 5.3.0 CDN) - Preserve OWASP Encoder usage for user inputs (don't replace with JSTL) - Correct import ordering in Step 1.2 (imports must come before security) - Enhance CSRF token guidance with project-specific implementation details - Add OpenO package naming examples (ca.openosp.openo.*) - Add PathValidationUtils security guidance for file operations - Make CSS XSS warning more prominent with safer alternatives - Fix JavaScript encoding example with proper variable retrieval - Add language identifier to markdown code block (markdownlint) Co-authored-by: Michael Yingbull <yingbull@users.noreply.github.com>
chore: JSP refactoring docs
…g format instead of epoch timestamp format. This caused Ocean eReferral imports to fail with a warning message when importing sent eReferrals back into the EMR.
Contributor
|
Fixed the merge conflicts |
…ob-epoch-format
Contributor
|
Additional Fix: Ocean eReferral Import DOB Format (Issue #1830) Context: Background |
…tion2 Fix: Syntax issue in function inside of AddReaction2.jsp
Contributor
|
Additional fix added: JavaScript Syntax Error in Allergy Dialog (Fixed in this PR: openo-beta#1861) Issue: Uncaught SyntaxError: expected expression, got '}' when clicking "Penicillin" (or other quick-add allergy buttons) in the ShowAllergies2.jsp page. Cause: Extra closing brace } in AddReaction2.jsp at line 173. The doSubmit() function had two closing braces instead of one: Fixed by: Removing the extra closing brace in src/main/webapp/oscarRx/AddReaction2.jsp. |
warrendennis
approved these changes
Jan 23, 2026
warrendennis
left a comment
warrendennis
left a comment
Collaborator
There was a problem hiding this comment.
Update package from Open O-beta approved for merge into Open O main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings the
openo-beta/Open-Ostaging branch changes to the upstreamopen-osp/Open-Omain branch. It includes significant improvements across multiple areas of the OpenO EMR system.Key Changes
1. Lab Format HL7 Generators (Feature)
CMLLabHL7GeneratorutilityMDSLabHL7Generatorwith comprehensive MDS-specific segment buildingGDMLLabHL7Generatorfor GDML format supportSubmitLabByForm2Actionfor modular lab format dispatchRelated PRs: #1604
2. Flowsheet Measurement Customization (Feature)
FlowSheetCustomizationServiceSpring serviceRelated PRs: #1078, #1399, #1401
3. Security Fixes
Related PRs: #1109, #1403, #1404, #1645, #1661, #1829
4. DevContainer & CI/CD Improvements
Related PRs: #823, #1664, #1796, #1402, #714
5. AI Tooling & Documentation
Related PRs: #1650, #1651, #1639, #1606, #1608, #1838
6. Bug Fixes
Related PRs: #1101, #1090, #1105, #1657, #1610, #1647, #1593
7. Dependency Updates
Related PRs: #1633, #1636, #1635, #1637, #1638
Complete PR List
All 64 merged PRs included in this release:
Related Issues
Issues addressed or referenced by commits in this release:
Test Plan
make install --run-testsBreaking Changes
None expected. All changes maintain backward compatibility.
Deployment Notes
RA_FORWORDproperty may need to be configured for billing reconciliationGenerated with Claude Code