-
Notifications
You must be signed in to change notification settings - Fork 126
SemConv 1.33.0 #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SemConv 1.33.0 #855
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
=======================================
Coverage 17.32% 17.32%
=======================================
Files 24 24
Lines 710 710
=======================================
Hits 123 123
Misses 587 587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
are you referring to |
|
Yeah, that was a weird one. I'm guessing we should just add that to the ignored namespaces since it effectively never existed in our releases? Seems like the easiest course of action. |
I'm curious why it never existed? |
|
From 1.27.0, so almost a year since the last release. I'm on my phone but I think they're new files which would mean we didn't have it before |
53a5114 to
6f58bf5
Compare
This is surely a nightmare for some but this version marks DB semantics as stable, so best to get it over with for Ecto before releasing that. Code attributes are also stable now.
Releases should be much easier now thanks to all the work the weaver team did.
Please pay special attention to the new namespaces and acronyms for acceptability. The
AZone not being in Azure is kinda weird tbh but that's the spec. 🤷🏻Android namespace was excluded in erlang but not elixir. Not sure which way to go on that one so just added it back to erlang for now for completeness.